OCPBUGS-29188: fix: resolve PV name via Symlink before comparing to KName

[jakobmoellerdev]

This allows us to properly exclude and filter symlinked devices that would previously be compared via kname without being resolved. Now we compare them symlinked which results in proper filter results

Added precommit timeout and incremented golang ci lint version

[openshift-ci-robot]

@jakobmoellerdev: This pull request references Jira Issue OCPBUGS-29188, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.16.0) matches configured target version for branch (4.16.0)
• bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @radeore

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

This allows us to properly exclude and filter symlinked devices that would previously be compared via kname without being resolved. Now we compare them symlinked which results in proper filter results

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[jakobmoellerdev]

Note to reviewer: the error here can be ignored as its the same as returning false

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jakobmoellerdev

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [jakobmoellerdev]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[codecov-commenter]

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (39f73d4) 82.47% compared to head (03ea2e3) 77.46%.
Report is 4 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #571      +/-   ##
==========================================
- Coverage   82.47%   77.46%   -5.01%     
==========================================
  Files          25       27       +2     
  Lines        1894     1948      +54     
==========================================
- Hits         1562     1509      -53     
- Misses        217      322     +105     
- Partials      115      117       +2     

Files	Coverage Δ
internal/controllers/vgmanager/devices.go	80.00% <100.00%> (ø)
internal/controllers/vgmanager/filter/filter.go	82.75% <50.00%> (-2.70%)	⬇️

... and 7 files with indirect coverage changes

[jakobmoellerdev]

/test precommit-check

[suleymanakbas91]

/lgtm

[suleymanakbas91]

/hold for unsigned commits

[openshift-ci-robot]

@jakobmoellerdev: This pull request references Jira Issue OCPBUGS-29188, which is valid.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.16.0) matches configured target version for branch (4.16.0)
• bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @radeore

In response to this:

This allows us to properly exclude and filter symlinked devices that would previously be compared via kname without being resolved. Now we compare them symlinked which results in proper filter results

Added precommit timeout and incremented golang ci lint version

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[jakobmoellerdev]

/test all

[jakobmoellerdev]

/test all

[jakobmoellerdev]

/test all

[jakobmoellerdev]

/test lvm-operator-e2e-aws
/test lvm-operator-e2e-aws-sno

[jakobmoellerdev]

/test lvm-operator-e2e-aws-sno

[openshift-ci]

@jakobmoellerdev: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[suleymanakbas91]

/lgtm

[jakobmoellerdev]

/unhold

[openshift-ci-robot]

@jakobmoellerdev: Jira Issue OCPBUGS-29188: All pull requests linked via external trackers have merged:

• openshift/lvm-operator#571

Jira Issue OCPBUGS-29188 has been moved to the MODIFIED state.

In response to this:

This allows us to properly exclude and filter symlinked devices that would previously be compared via kname without being resolved. Now we compare them symlinked which results in proper filter results

Added precommit timeout and incremented golang ci lint version

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[jakobmoellerdev]

/cherry-pick release-4.15

[openshift-cherrypick-robot]

@jakobmoellerdev: #571 failed to apply on top of branch "release-4.15":

Applying: fix: resolve PV name before comparing to KName
Using index info to reconstruct a base tree...
M	internal/controllers/vgmanager/devices.go
M	internal/controllers/vgmanager/filter/filter.go
M	internal/controllers/vgmanager/filter/filter_test.go
Falling back to patching base and 3-way merge...
Auto-merging internal/controllers/vgmanager/filter/filter_test.go
Auto-merging internal/controllers/vgmanager/filter/filter.go
CONFLICT (content): Merge conflict in internal/controllers/vgmanager/filter/filter.go
Auto-merging internal/controllers/vgmanager/devices.go
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 fix: resolve PV name before comparing to KName
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherry-pick release-4.15

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.