Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCPEDGE-810: chore: remove pre 4.16 components from cluster on startup #564

Merged

Conversation

jakobmoellerdev
Copy link
Contributor

@jakobmoellerdev jakobmoellerdev commented Jan 30, 2024

Removes 4.16 Components (topolvm controller, topolvm node daemonset, and leftover leases) from the cluster if they are still there as they wouldnt get removed by OLM during upgrades.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jan 30, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jan 30, 2024

@jakobmoellerdev: This pull request references OCPEDGE-810 which is a valid jira issue.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 30, 2024
Copy link
Contributor

openshift-ci bot commented Jan 30, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci openshift-ci bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jan 30, 2024
Copy link
Contributor

openshift-ci bot commented Jan 30, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jakobmoellerdev

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 30, 2024
@jakobmoellerdev jakobmoellerdev force-pushed the OCPEDGE-810-cleanup branch 2 times, most recently from 9e2edfb to c15097b Compare January 30, 2024 10:54
@jakobmoellerdev jakobmoellerdev marked this pull request as ready for review January 30, 2024 10:56
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 30, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jan 30, 2024

@jakobmoellerdev: This pull request references OCPEDGE-810 which is a valid jira issue.

In response to this:

Removes 4.16 Components (topolvm controller, topolvm node daemonset, and leftover leases) from the cluster if they are still there as they wouldnt get removed by OLM during upgrades.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Signed-off-by: Jakob Möller <jmoller@redhat.com>
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (0a16e1e) 81.74% compared to head (5ae53f1) 82.33%.
Report is 2 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #564      +/-   ##
==========================================
+ Coverage   81.74%   82.33%   +0.58%     
==========================================
  Files          24       25       +1     
  Lines        1819     1868      +49     
==========================================
+ Hits         1487     1538      +51     
+ Misses        218      217       -1     
+ Partials      114      113       -1     
Files Coverage Δ
internal/cluster/leaderelection.go 100.00% <100.00%> (ø)
internal/controllers/lvmcluster/controller.go 63.23% <ø> (+0.98%) ⬆️
internal/migration/microlvms/cleanup.go 100.00% <100.00%> (ø)
internal/migration/tagging/tagging.go 66.66% <ø> (ø)

@jakobmoellerdev
Copy link
Contributor Author

/override ci/prow/precommit-check

Copy link
Contributor

openshift-ci bot commented Jan 30, 2024

@jakobmoellerdev: Overrode contexts on behalf of jakobmoellerdev: ci/prow/precommit-check

In response to this:

/override ci/prow/precommit-check

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Contributor

openshift-ci bot commented Jan 30, 2024

@jakobmoellerdev: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@suleymanakbas91
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 30, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 382b4ae into openshift:main Jan 30, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants