Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NO-JIRA: fix: do not set resource version in lvmcluster test #554

Conversation

jakobmoellerdev
Copy link
Contributor

Signed-off-by: Jakob Möller <jmoller@redhat.com>
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jan 23, 2024
@openshift-ci-robot
Copy link

@jakobmoellerdev: This pull request explicitly references no jira issue.

In response to this:

Addresses the failure in the recent main run that was coming up during test execution

https://prow.ci.openshift.org/view/gs/test-platform-results/logs/branch-ci-openshift-lvm-operator-main-post-unit-test/1749362544251768832#1:build-log.txt%3A133

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jan 23, 2024
Copy link
Contributor

openshift-ci bot commented Jan 23, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jakobmoellerdev

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 23, 2024
@codecov-commenter
Copy link

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (9183a91) 81.85% compared to head (94879b7) 81.74%.
Report is 2 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #554      +/-   ##
==========================================
- Coverage   81.85%   81.74%   -0.11%     
==========================================
  Files          24       24              
  Lines        1819     1819              
==========================================
- Hits         1489     1487       -2     
- Misses        216      218       +2     
  Partials      114      114              
Files Coverage Δ
internal/controllers/lvmcluster/controller.go 62.25% <100.00%> (ø)
internal/controllers/node/removal/controller.go 100.00% <100.00%> (ø)
internal/controllers/vgmanager/controller.go 74.39% <50.00%> (-0.49%) ⬇️

@suleymanakbas91
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 23, 2024
@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD afcbcc2 and 2 for PR HEAD 94879b7 in total

@jakobmoellerdev
Copy link
Contributor Author

/test lvm-operator-e2e-aws-sno

@openshift-merge-bot openshift-merge-bot bot merged commit 2254a18 into openshift:main Jan 23, 2024
9 checks passed
Copy link
Contributor

openshift-ci bot commented Jan 23, 2024

@jakobmoellerdev: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants