Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCPVE-710: chore: bump OPERATOR_SDK_VERSION to 1.32.0 #442

Merged

Conversation

jakobmoellerdev
Copy link
Contributor

Also adds a sed modification to remove createdAt from the bundle to avoid change detection triggers. Since its a generic annotation and the bundle validate succeeds we can assume this is safe

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Oct 6, 2023
@openshift-ci-robot
Copy link

openshift-ci-robot commented Oct 6, 2023

@jakobmoellerdev: This pull request references OCPVE-710 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.15.0" version, but no target version was set.

In response to this:

Also adds a sed modification to remove createdAt from the bundle to avoid change detection triggers. Since its a generic annotation and the bundle validate succeeds we can assume this is safe

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Oct 6, 2023
@openshift-ci-robot
Copy link

openshift-ci-robot commented Oct 6, 2023

@jakobmoellerdev: This pull request references OCPVE-710 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.15.0" version, but no target version was set.

In response to this:

Also adds a sed modification to remove createdAt from the bundle to avoid change detection triggers. Since its a generic annotation and the bundle validate succeeds we can assume this is safe

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@codecov-commenter
Copy link

codecov-commenter commented Oct 6, 2023

Codecov Report

Merging #442 (c5a7a25) into main (4d94695) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #442   +/-   ##
=======================================
  Coverage   59.41%   59.41%           
=======================================
  Files          21       21           
  Lines        1614     1614           
=======================================
  Hits          959      959           
  Misses        539      539           
  Partials      116      116           

@jakobmoellerdev
Copy link
Contributor Author

/test lvm-operator-e2e-aws-sno

2 similar comments
@jakobmoellerdev
Copy link
Contributor Author

/test lvm-operator-e2e-aws-sno

@jakobmoellerdev
Copy link
Contributor Author

/test lvm-operator-e2e-aws-sno

Makefile Outdated Show resolved Hide resolved
@jakobmoellerdev jakobmoellerdev force-pushed the OCPVE-710-operator-sdk-upgrade branch 5 times, most recently from 3627351 to a5eb285 Compare October 9, 2023 12:16
Signed-off-by: Jakob Möller <jmoller@redhat.com>
@suleymanakbas91
Copy link
Contributor

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 9, 2023
@openshift-ci-robot
Copy link

openshift-ci-robot commented Oct 9, 2023

@jakobmoellerdev: This pull request references OCPVE-710 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.15.0" version, but no target version was set.

In response to this:

Also adds a sed modification to remove createdAt from the bundle to avoid change detection triggers. Since its a generic annotation and the bundle validate succeeds we can assume this is safe

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 9, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jakobmoellerdev, suleymanakbas91

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 9, 2023
@openshift-ci-robot
Copy link

openshift-ci-robot commented Oct 9, 2023

@jakobmoellerdev: This pull request references OCPVE-710 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.15.0" version, but no target version was set.

In response to this:

Also adds a sed modification to remove createdAt from the bundle to avoid change detection triggers. Since its a generic annotation and the bundle validate succeeds we can assume this is safe

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jakobmoellerdev
Copy link
Contributor Author

/test lvm-operator-e2e-aws

1 similar comment
@jakobmoellerdev
Copy link
Contributor Author

/test lvm-operator-e2e-aws

@jakobmoellerdev
Copy link
Contributor Author

/test lvm-operator-e2e-aws-sno

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 1f8a77b and 2 for PR HEAD c5a7a25 in total

@jakobmoellerdev
Copy link
Contributor Author

/test lvm-operator-e2e-aws

@jakobmoellerdev
Copy link
Contributor Author

/test lvm-operator-e2e-aws

1 similar comment
@jakobmoellerdev
Copy link
Contributor Author

/test lvm-operator-e2e-aws

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 9, 2023

@jakobmoellerdev: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-ci openshift-ci bot merged commit 2d2c100 into openshift:main Oct 9, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants