Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OCPVE-343: feat: allow passthrough for log flags #440

Merged
merged 1 commit into from
Oct 6, 2023
Merged

OCPVE-343: feat: allow passthrough for log flags #440

merged 1 commit into from
Oct 6, 2023

Conversation

jakobmoellerdev
Copy link
Contributor

@jakobmoellerdev jakobmoellerdev commented Oct 5, 2023 •
edited
Loading

Allows passing through log verbosity settings for vgmanager, topolvm-controller, topolvm-node and lvmd and all csi-sidecar containers (resizer, snapshotter, external-provisioner, registrar). The flags are passed generically with a prefix that is attached to them and they will only be passed if they differ from the default value. LVMD supports less than usual flags as it uses a legacy logging library from cybozu.

This is the new help with all flags available in the operator:

./bin/lvms operator --help
Operator reconciling LVMCluster LVMVolumeGroup and LVMVolumeGroupNodeStatus

Usage:
  lvms operator [flags]

Flags:
      --csi-sidecar-v string                      csi-sidecar: number for the log level verbosity
      --csi-sidecar-vmodule string                csi-sidecar: comma-separated list of pattern=N settings for file-filtered logging
      --diagnostics-address string                The address the diagnostics endpoint binds to. (default ":8443")
      --health-probe-bind-address string          The address the probe endpoint binds to. (default ":8081")
  -h, --help                                      help for operator
      --leader-elect                              Enable leader election for controller manager. Enabling this will ensure there is only one active controller manager.
      --lvmd-loglevel string                      Log level [critical,error,warning,info,debug]
      --topolvm-controller-v string               topolvm-controller: number for the log level verbosity
      --topolvm-controller-vmodule string         topolvm-controller: comma-separated list of pattern=N settings for file-filtered logging
      --topolvm-controller-zap-log-level string   topolvm-controller: Zap Level to configure the verbosity of logging. Can be one of 'debug', 'info', 'error', or any integer value > 0 which corresponds to custom debug levels of increasing verbosity
      --topolvm-node-v string                     topolvm-node: number for the log level verbosity
      --topolvm-node-vmodule string               topolvm-node: comma-separated list of pattern=N settings for file-filtered logging
      --topolvm-node-zap-log-level string         topolvm-node: Zap Level to configure the verbosity of logging. Can be one of 'debug', 'info', 'error', or any integer value > 0 which corresponds to custom debug levels of increasing verbosity
      --vgmanager-cmd strings                     The command that should be used to start vgmanager on the node. Useful for debugging purposes but normally not changed. (default [/lvms,vgmanager])
      --vgmanager-v string                        vgmanager: number for the log level verbosity
      --vgmanager-vmodule string                  vgmanager: comma-separated list of pattern=N settings for file-filtered logging
      --vgmanager-zap-log-level string            vgmanager: Zap Level to configure the verbosity of logging. Can be one of 'debug', 'info', 'error', or any integer value > 0 which corresponds to custom debug levels of increasing verbosity

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Oct 5, 2023
@openshift-ci-robot
Copy link

openshift-ci-robot commented Oct 5, 2023 •
edited by openshift-ci bot
Loading

@jakobmoellerdev: This pull request references OCPVE-343 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.15.0" version, but no target version was set.

In response to this:

Allows passing through all log settings for vgmanager, topolvm-controller, topolvm-node and lvmd and all csi-sidecar containers (resizer, snapshotter, external-provisioner, registrar). The flags are passed generically with a prefix that is attached to them and they will only be passed if they differ from the default value. LVMD supports less than usual flags as it uses a legacy logging library from cybozu.

This is the new help with all flags available in the operator:

./bin/lvms operator --help
Operator reconciling LVMCluster LVMVolumeGroup and LVMVolumeGroupNodeStatus

Usage:
 lvms operator [flags]

Flags:
     --csi-sidecar-add_dir_header                           CSI Sidecar: If true, adds the file directory to the header of the log messages
     --csi-sidecar-alsologtostderr                          CSI Sidecar: log to standard error as well as files (no effect when -logtostderr=true)
     --csi-sidecar-log_backtrace_at traceLocation           CSI Sidecar: when logging hits line file:N, emit a stack trace (default :0)
     --csi-sidecar-log_dir string                           CSI Sidecar: If non-empty, write log files in this directory (no effect when -logtostderr=true)
     --csi-sidecar-log_file string                          CSI Sidecar: If non-empty, use this log file (no effect when -logtostderr=true)
     --csi-sidecar-log_file_max_size uint                   CSI Sidecar: Defines the maximum size a log file can grow to (no effect when -logtostderr=true). Unit is megabytes. If the value is 0, the maximum file size is unlimited. (default 1800)
     --csi-sidecar-logtostderr                              CSI Sidecar: log to standard error instead of files (default true)
     --csi-sidecar-one_output                               CSI Sidecar: If true, only write logs to their native severity level (vs also writing to each lower severity level; no effect when -logtostderr=true)
     --csi-sidecar-skip_headers                             CSI Sidecar: If true, avoid header prefixes in the log messages
     --csi-sidecar-skip_log_headers                         CSI Sidecar: If true, avoid headers when opening log files (no effect when -logtostderr=true)
     --csi-sidecar-stderrthreshold severity                 CSI Sidecar: logs at or above this threshold go to stderr when writing to files and stderr (no effect when -logtostderr=true or -alsologtostderr=false) (default 2)
     --csi-sidecar-v Level                                  CSI Sidecar: number for the log level verbosity
     --csi-sidecar-vmodule moduleSpec                       CSI Sidecar: comma-separated list of pattern=N settings for file-filtered logging
     --diagnostics-address string                           The address the diagnostics endpoint binds to. (default ":8443")
     --health-probe-bind-address string                     The address the probe endpoint binds to. (default ":8081")
 -h, --help                                                 help for operator
     --leader-elect                                         Enable leader election for controller manager. Enabling this will ensure there is only one active controller manager.
     --lvmd-logfile string                                  LVMD: Log filename
     --lvmd-logformat string                                LVMD: Log format [plain,logfmt,json]
     --lvmd-loglevel string                                 LVMD: Log level [critical,error,warning,info,debug]
     --topolvm-controller-add_dir_header                    TopoLVM Controller: If true, adds the file directory to the header of the log messages
     --topolvm-controller-alsologtostderr                   TopoLVM Controller: log to standard error as well as files (no effect when -logtostderr=true)
     --topolvm-controller-log_backtrace_at traceLocation    TopoLVM Controller: when logging hits line file:N, emit a stack trace (default :0)
     --topolvm-controller-log_dir string                    TopoLVM Controller: If non-empty, write log files in this directory (no effect when -logtostderr=true)
     --topolvm-controller-log_file string                   TopoLVM Controller: If non-empty, use this log file (no effect when -logtostderr=true)
     --topolvm-controller-log_file_max_size uint            TopoLVM Controller: Defines the maximum size a log file can grow to (no effect when -logtostderr=true). Unit is megabytes. If the value is 0, the maximum file size is unlimited. (default 1800)
     --topolvm-controller-logtostderr                       TopoLVM Controller: log to standard error instead of files (default true)
     --topolvm-controller-one_output                        TopoLVM Controller: If true, only write logs to their native severity level (vs also writing to each lower severity level; no effect when -logtostderr=true)
     --topolvm-controller-skip_headers                      TopoLVM Controller: If true, avoid header prefixes in the log messages
     --topolvm-controller-skip_log_headers                  TopoLVM Controller: If true, avoid headers when opening log files (no effect when -logtostderr=true)
     --topolvm-controller-stderrthreshold severity          TopoLVM Controller: logs at or above this threshold go to stderr when writing to files and stderr (no effect when -logtostderr=true or -alsologtostderr=false) (default 2)
     --topolvm-controller-v Level                           TopoLVM Controller: number for the log level verbosity
     --topolvm-controller-vmodule moduleSpec                TopoLVM Controller: comma-separated list of pattern=N settings for file-filtered logging
     --topolvm-controller-zap-devel                         TopoLVM Controller: Development Mode defaults(encoder=consoleEncoder,logLevel=Debug,stackTraceLevel=Warn). Production Mode defaults(encoder=jsonEncoder,logLevel=Info,stackTraceLevel=Error)
     --topolvm-controller-zap-encoder encoder               TopoLVM Controller: Zap log encoding (one of 'json' or 'console')
     --topolvm-controller-zap-log-level level               TopoLVM Controller: Zap Level to configure the verbosity of logging. Can be one of 'debug', 'info', 'error', or any integer value > 0 which corresponds to custom debug levels of increasing verbosity
     --topolvm-controller-zap-stacktrace-level level        TopoLVM Controller: Zap Level at and above which stacktraces are captured (one of 'info', 'error', 'panic').
     --topolvm-controller-zap-time-encoding time-encoding   TopoLVM Controller: Zap time encoding (one of 'epoch', 'millis', 'nano', 'iso8601', 'rfc3339' or 'rfc3339nano'). Defaults to 'epoch'.
     --topolvm-node-add_dir_header                          TopoLVM Node: If true, adds the file directory to the header of the log messages
     --topolvm-node-alsologtostderr                         TopoLVM Node: log to standard error as well as files (no effect when -logtostderr=true)
     --topolvm-node-log_backtrace_at traceLocation          TopoLVM Node: when logging hits line file:N, emit a stack trace (default :0)
     --topolvm-node-log_dir string                          TopoLVM Node: If non-empty, write log files in this directory (no effect when -logtostderr=true)
     --topolvm-node-log_file string                         TopoLVM Node: If non-empty, use this log file (no effect when -logtostderr=true)
     --topolvm-node-log_file_max_size uint                  TopoLVM Node: Defines the maximum size a log file can grow to (no effect when -logtostderr=true). Unit is megabytes. If the value is 0, the maximum file size is unlimited. (default 1800)
     --topolvm-node-logtostderr                             TopoLVM Node: log to standard error instead of files (default true)
     --topolvm-node-one_output                              TopoLVM Node: If true, only write logs to their native severity level (vs also writing to each lower severity level; no effect when -logtostderr=true)
     --topolvm-node-skip_headers                            TopoLVM Node: If true, avoid header prefixes in the log messages
     --topolvm-node-skip_log_headers                        TopoLVM Node: If true, avoid headers when opening log files (no effect when -logtostderr=true)
     --topolvm-node-stderrthreshold severity                TopoLVM Node: logs at or above this threshold go to stderr when writing to files and stderr (no effect when -logtostderr=true or -alsologtostderr=false) (default 2)
     --topolvm-node-v Level                                 TopoLVM Node: number for the log level verbosity
     --topolvm-node-vmodule moduleSpec                      TopoLVM Node: comma-separated list of pattern=N settings for file-filtered logging
     --topolvm-node-zap-devel                               TopoLVM Node: Development Mode defaults(encoder=consoleEncoder,logLevel=Debug,stackTraceLevel=Warn). Production Mode defaults(encoder=jsonEncoder,logLevel=Info,stackTraceLevel=Error)
     --topolvm-node-zap-encoder encoder                     TopoLVM Node: Zap log encoding (one of 'json' or 'console')
     --topolvm-node-zap-log-level level                     TopoLVM Node: Zap Level to configure the verbosity of logging. Can be one of 'debug', 'info', 'error', or any integer value > 0 which corresponds to custom debug levels of increasing verbosity
     --topolvm-node-zap-stacktrace-level level              TopoLVM Node: Zap Level at and above which stacktraces are captured (one of 'info', 'error', 'panic').
     --topolvm-node-zap-time-encoding time-encoding         TopoLVM Node: Zap time encoding (one of 'epoch', 'millis', 'nano', 'iso8601', 'rfc3339' or 'rfc3339nano'). Defaults to 'epoch'.
     --vgmanager-add_dir_header                             vgmanager: If true, adds the file directory to the header of the log messages
     --vgmanager-alsologtostderr                            vgmanager: log to standard error as well as files (no effect when -logtostderr=true)
     --vgmanager-cmd strings                                The command that should be used to start vgmanager on the node. Useful for debugging purposes but normally not changed. (default [/lvms,vgmanager])
     --vgmanager-log_backtrace_at traceLocation             vgmanager: when logging hits line file:N, emit a stack trace (default :0)
     --vgmanager-log_dir string                             vgmanager: If non-empty, write log files in this directory (no effect when -logtostderr=true)
     --vgmanager-log_file string                            vgmanager: If non-empty, use this log file (no effect when -logtostderr=true)
     --vgmanager-log_file_max_size uint                     vgmanager: Defines the maximum size a log file can grow to (no effect when -logtostderr=true). Unit is megabytes. If the value is 0, the maximum file size is unlimited. (default 1800)
     --vgmanager-logtostderr                                vgmanager: log to standard error instead of files (default true)
     --vgmanager-one_output                                 vgmanager: If true, only write logs to their native severity level (vs also writing to each lower severity level; no effect when -logtostderr=true)
     --vgmanager-skip_headers                               vgmanager: If true, avoid header prefixes in the log messages
     --vgmanager-skip_log_headers                           vgmanager: If true, avoid headers when opening log files (no effect when -logtostderr=true)
     --vgmanager-stderrthreshold severity                   vgmanager: logs at or above this threshold go to stderr when writing to files and stderr (no effect when -logtostderr=true or -alsologtostderr=false) (default 2)
     --vgmanager-v Level                                    vgmanager: number for the log level verbosity
     --vgmanager-vmodule moduleSpec                         vgmanager: comma-separated list of pattern=N settings for file-filtered logging
     --vgmanager-zap-devel                                  vgmanager: Development Mode defaults(encoder=consoleEncoder,logLevel=Debug,stackTraceLevel=Warn). Production Mode defaults(encoder=jsonEncoder,logLevel=Info,stackTraceLevel=Error)
     --vgmanager-zap-encoder encoder                        vgmanager: Zap log encoding (one of 'json' or 'console')
     --vgmanager-zap-log-level level                        vgmanager: Zap Level to configure the verbosity of logging. Can be one of 'debug', 'info', 'error', or any integer value > 0 which corresponds to custom debug levels of increasing verbosity
     --vgmanager-zap-stacktrace-level level                 vgmanager: Zap Level at and above which stacktraces are captured (one of 'info', 'error', 'panic').
     --vgmanager-zap-time-encoding time-encoding            vgmanager: Zap time encoding (one of 'epoch', 'millis', 'nano', 'iso8601', 'rfc3339' or 'rfc3339nano'). Defaults to 'epoch'.

Global Flags:
     --add_dir_header                    If true, adds the file directory to the header of the log messages
     --alsologtostderr                   log to standard error as well as files (no effect when -logtostderr=true)
     --log_backtrace_at traceLocation    when logging hits line file:N, emit a stack trace (default :0)
     --log_dir string                    If non-empty, write log files in this directory (no effect when -logtostderr=true)
     --log_file string                   If non-empty, use this log file (no effect when -logtostderr=true)
     --log_file_max_size uint            Defines the maximum size a log file can grow to (no effect when -logtostderr=true). Unit is megabytes. If the value is 0, the maximum file size is unlimited. (default 1800)
     --logfile string                    Log filename
     --logformat string                  Log format [plain,logfmt,json]
     --loglevel string                   Log level [critical,error,warning,info,debug]
     --logtostderr                       log to standard error instead of files (default true)
     --one_output                        If true, only write logs to their native severity level (vs also writing to each lower severity level; no effect when -logtostderr=true)
     --skip_headers                      If true, avoid header prefixes in the log messages
     --skip_log_headers                  If true, avoid headers when opening log files (no effect when -logtostderr=true)
     --stderrthreshold severity          logs at or above this threshold go to stderr when writing to files and stderr (no effect when -logtostderr=true or -alsologtostderr=false) (default 2)
 -v, --v Level                           number for the log level verbosity
     --vmodule moduleSpec                comma-separated list of pattern=N settings for file-filtered logging
     --zap-devel                         Development Mode defaults(encoder=consoleEncoder,logLevel=Debug,stackTraceLevel=Warn). Production Mode defaults(encoder=jsonEncoder,logLevel=Info,stackTraceLevel=Error)
     --zap-encoder encoder               Zap log encoding (one of 'json' or 'console')
     --zap-log-level level               Zap Level to configure the verbosity of logging. Can be one of 'debug', 'info', 'error', or any integer value > 0 which corresponds to custom debug levels of increasing verbosity
     --zap-stacktrace-level level        Zap Level at and above which stacktraces are captured (one of 'info', 'error', 'panic').
     --zap-time-encoding time-encoding   Zap time encoding (one of 'epoch', 'millis', 'nano', 'iso8601', 'rfc3339' or 'rfc3339nano'). Defaults to 'epoch'.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Oct 5, 2023
@openshift-ci-robot
Copy link

openshift-ci-robot commented Oct 5, 2023 •
edited by openshift-ci bot
Loading

@jakobmoellerdev: This pull request references OCPVE-343 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.15.0" version, but no target version was set.

In response to this:

Allows passing through all log settings for vgmanager, topolvm-controller, topolvm-node and lvmd and all csi-sidecar containers (resizer, snapshotter, external-provisioner, registrar). The flags are passed generically with a prefix that is attached to them and they will only be passed if they differ from the default value. LVMD supports less than usual flags as it uses a legacy logging library from cybozu.

This is the new help with all flags available in the operator:

./bin/lvms operator --help
Operator reconciling LVMCluster LVMVolumeGroup and LVMVolumeGroupNodeStatus

Usage:
 lvms operator [flags]

Flags:
     --csi-sidecar-add_dir_header                           CSI Sidecar: If true, adds the file directory to the header of the log messages
     --csi-sidecar-alsologtostderr                          CSI Sidecar: log to standard error as well as files (no effect when -logtostderr=true)
     --csi-sidecar-log_backtrace_at traceLocation           CSI Sidecar: when logging hits line file:N, emit a stack trace (default :0)
     --csi-sidecar-log_dir string                           CSI Sidecar: If non-empty, write log files in this directory (no effect when -logtostderr=true)
     --csi-sidecar-log_file string                          CSI Sidecar: If non-empty, use this log file (no effect when -logtostderr=true)
     --csi-sidecar-log_file_max_size uint                   CSI Sidecar: Defines the maximum size a log file can grow to (no effect when -logtostderr=true). Unit is megabytes. If the value is 0, the maximum file size is unlimited. (default 1800)
     --csi-sidecar-logtostderr                              CSI Sidecar: log to standard error instead of files (default true)
     --csi-sidecar-one_output                               CSI Sidecar: If true, only write logs to their native severity level (vs also writing to each lower severity level; no effect when -logtostderr=true)
     --csi-sidecar-skip_headers                             CSI Sidecar: If true, avoid header prefixes in the log messages
     --csi-sidecar-skip_log_headers                         CSI Sidecar: If true, avoid headers when opening log files (no effect when -logtostderr=true)
     --csi-sidecar-stderrthreshold severity                 CSI Sidecar: logs at or above this threshold go to stderr when writing to files and stderr (no effect when -logtostderr=true or -alsologtostderr=false) (default 2)
     --csi-sidecar-v Level                                  CSI Sidecar: number for the log level verbosity
     --csi-sidecar-vmodule moduleSpec                       CSI Sidecar: comma-separated list of pattern=N settings for file-filtered logging
     --diagnostics-address string                           The address the diagnostics endpoint binds to. (default ":8443")
     --health-probe-bind-address string                     The address the probe endpoint binds to. (default ":8081")
 -h, --help                                                 help for operator
     --leader-elect                                         Enable leader election for controller manager. Enabling this will ensure there is only one active controller manager.
     --lvmd-logfile string                                  LVMD: Log filename
     --lvmd-logformat string                                LVMD: Log format [plain,logfmt,json]
     --lvmd-loglevel string                                 LVMD: Log level [critical,error,warning,info,debug]
     --topolvm-controller-add_dir_header                    TopoLVM Controller: If true, adds the file directory to the header of the log messages
     --topolvm-controller-alsologtostderr                   TopoLVM Controller: log to standard error as well as files (no effect when -logtostderr=true)
     --topolvm-controller-log_backtrace_at traceLocation    TopoLVM Controller: when logging hits line file:N, emit a stack trace (default :0)
     --topolvm-controller-log_dir string                    TopoLVM Controller: If non-empty, write log files in this directory (no effect when -logtostderr=true)
     --topolvm-controller-log_file string                   TopoLVM Controller: If non-empty, use this log file (no effect when -logtostderr=true)
     --topolvm-controller-log_file_max_size uint            TopoLVM Controller: Defines the maximum size a log file can grow to (no effect when -logtostderr=true). Unit is megabytes. If the value is 0, the maximum file size is unlimited. (default 1800)
     --topolvm-controller-logtostderr                       TopoLVM Controller: log to standard error instead of files (default true)
     --topolvm-controller-one_output                        TopoLVM Controller: If true, only write logs to their native severity level (vs also writing to each lower severity level; no effect when -logtostderr=true)
     --topolvm-controller-skip_headers                      TopoLVM Controller: If true, avoid header prefixes in the log messages
     --topolvm-controller-skip_log_headers                  TopoLVM Controller: If true, avoid headers when opening log files (no effect when -logtostderr=true)
     --topolvm-controller-stderrthreshold severity          TopoLVM Controller: logs at or above this threshold go to stderr when writing to files and stderr (no effect when -logtostderr=true or -alsologtostderr=false) (default 2)
     --topolvm-controller-v Level                           TopoLVM Controller: number for the log level verbosity
     --topolvm-controller-vmodule moduleSpec                TopoLVM Controller: comma-separated list of pattern=N settings for file-filtered logging
     --topolvm-controller-zap-devel                         TopoLVM Controller: Development Mode defaults(encoder=consoleEncoder,logLevel=Debug,stackTraceLevel=Warn). Production Mode defaults(encoder=jsonEncoder,logLevel=Info,stackTraceLevel=Error)
     --topolvm-controller-zap-encoder encoder               TopoLVM Controller: Zap log encoding (one of 'json' or 'console')
     --topolvm-controller-zap-log-level level               TopoLVM Controller: Zap Level to configure the verbosity of logging. Can be one of 'debug', 'info', 'error', or any integer value > 0 which corresponds to custom debug levels of increasing verbosity
     --topolvm-controller-zap-stacktrace-level level        TopoLVM Controller: Zap Level at and above which stacktraces are captured (one of 'info', 'error', 'panic').
     --topolvm-controller-zap-time-encoding time-encoding   TopoLVM Controller: Zap time encoding (one of 'epoch', 'millis', 'nano', 'iso8601', 'rfc3339' or 'rfc3339nano'). Defaults to 'epoch'.
     --topolvm-node-add_dir_header                          TopoLVM Node: If true, adds the file directory to the header of the log messages
     --topolvm-node-alsologtostderr                         TopoLVM Node: log to standard error as well as files (no effect when -logtostderr=true)
     --topolvm-node-log_backtrace_at traceLocation          TopoLVM Node: when logging hits line file:N, emit a stack trace (default :0)
     --topolvm-node-log_dir string                          TopoLVM Node: If non-empty, write log files in this directory (no effect when -logtostderr=true)
     --topolvm-node-log_file string                         TopoLVM Node: If non-empty, use this log file (no effect when -logtostderr=true)
     --topolvm-node-log_file_max_size uint                  TopoLVM Node: Defines the maximum size a log file can grow to (no effect when -logtostderr=true). Unit is megabytes. If the value is 0, the maximum file size is unlimited. (default 1800)
     --topolvm-node-logtostderr                             TopoLVM Node: log to standard error instead of files (default true)
     --topolvm-node-one_output                              TopoLVM Node: If true, only write logs to their native severity level (vs also writing to each lower severity level; no effect when -logtostderr=true)
     --topolvm-node-skip_headers                            TopoLVM Node: If true, avoid header prefixes in the log messages
     --topolvm-node-skip_log_headers                        TopoLVM Node: If true, avoid headers when opening log files (no effect when -logtostderr=true)
     --topolvm-node-stderrthreshold severity                TopoLVM Node: logs at or above this threshold go to stderr when writing to files and stderr (no effect when -logtostderr=true or -alsologtostderr=false) (default 2)
     --topolvm-node-v Level                                 TopoLVM Node: number for the log level verbosity
     --topolvm-node-vmodule moduleSpec                      TopoLVM Node: comma-separated list of pattern=N settings for file-filtered logging
     --topolvm-node-zap-devel                               TopoLVM Node: Development Mode defaults(encoder=consoleEncoder,logLevel=Debug,stackTraceLevel=Warn). Production Mode defaults(encoder=jsonEncoder,logLevel=Info,stackTraceLevel=Error)
     --topolvm-node-zap-encoder encoder                     TopoLVM Node: Zap log encoding (one of 'json' or 'console')
     --topolvm-node-zap-log-level level                     TopoLVM Node: Zap Level to configure the verbosity of logging. Can be one of 'debug', 'info', 'error', or any integer value > 0 which corresponds to custom debug levels of increasing verbosity
     --topolvm-node-zap-stacktrace-level level              TopoLVM Node: Zap Level at and above which stacktraces are captured (one of 'info', 'error', 'panic').
     --topolvm-node-zap-time-encoding time-encoding         TopoLVM Node: Zap time encoding (one of 'epoch', 'millis', 'nano', 'iso8601', 'rfc3339' or 'rfc3339nano'). Defaults to 'epoch'.
     --vgmanager-add_dir_header                             vgmanager: If true, adds the file directory to the header of the log messages
     --vgmanager-alsologtostderr                            vgmanager: log to standard error as well as files (no effect when -logtostderr=true)
     --vgmanager-cmd strings                                The command that should be used to start vgmanager on the node. Useful for debugging purposes but normally not changed. (default [/lvms,vgmanager])
     --vgmanager-log_backtrace_at traceLocation             vgmanager: when logging hits line file:N, emit a stack trace (default :0)
     --vgmanager-log_dir string                             vgmanager: If non-empty, write log files in this directory (no effect when -logtostderr=true)
     --vgmanager-log_file string                            vgmanager: If non-empty, use this log file (no effect when -logtostderr=true)
     --vgmanager-log_file_max_size uint                     vgmanager: Defines the maximum size a log file can grow to (no effect when -logtostderr=true). Unit is megabytes. If the value is 0, the maximum file size is unlimited. (default 1800)
     --vgmanager-logtostderr                                vgmanager: log to standard error instead of files (default true)
     --vgmanager-one_output                                 vgmanager: If true, only write logs to their native severity level (vs also writing to each lower severity level; no effect when -logtostderr=true)
     --vgmanager-skip_headers                               vgmanager: If true, avoid header prefixes in the log messages
     --vgmanager-skip_log_headers                           vgmanager: If true, avoid headers when opening log files (no effect when -logtostderr=true)
     --vgmanager-stderrthreshold severity                   vgmanager: logs at or above this threshold go to stderr when writing to files and stderr (no effect when -logtostderr=true or -alsologtostderr=false) (default 2)
     --vgmanager-v Level                                    vgmanager: number for the log level verbosity
     --vgmanager-vmodule moduleSpec                         vgmanager: comma-separated list of pattern=N settings for file-filtered logging
     --vgmanager-zap-devel                                  vgmanager: Development Mode defaults(encoder=consoleEncoder,logLevel=Debug,stackTraceLevel=Warn). Production Mode defaults(encoder=jsonEncoder,logLevel=Info,stackTraceLevel=Error)
     --vgmanager-zap-encoder encoder                        vgmanager: Zap log encoding (one of 'json' or 'console')
     --vgmanager-zap-log-level level                        vgmanager: Zap Level to configure the verbosity of logging. Can be one of 'debug', 'info', 'error', or any integer value > 0 which corresponds to custom debug levels of increasing verbosity
     --vgmanager-zap-stacktrace-level level                 vgmanager: Zap Level at and above which stacktraces are captured (one of 'info', 'error', 'panic').
     --vgmanager-zap-time-encoding time-encoding            vgmanager: Zap time encoding (one of 'epoch', 'millis', 'nano', 'iso8601', 'rfc3339' or 'rfc3339nano'). Defaults to 'epoch'.

Global Flags:
     --add_dir_header                    If true, adds the file directory to the header of the log messages
     --alsologtostderr                   log to standard error as well as files (no effect when -logtostderr=true)
     --log_backtrace_at traceLocation    when logging hits line file:N, emit a stack trace (default :0)
     --log_dir string                    If non-empty, write log files in this directory (no effect when -logtostderr=true)
     --log_file string                   If non-empty, use this log file (no effect when -logtostderr=true)
     --log_file_max_size uint            Defines the maximum size a log file can grow to (no effect when -logtostderr=true). Unit is megabytes. If the value is 0, the maximum file size is unlimited. (default 1800)
     --logfile string                    Log filename
     --logformat string                  Log format [plain,logfmt,json]
     --loglevel string                   Log level [critical,error,warning,info,debug]
     --logtostderr                       log to standard error instead of files (default true)
     --one_output                        If true, only write logs to their native severity level (vs also writing to each lower severity level; no effect when -logtostderr=true)
     --skip_headers                      If true, avoid header prefixes in the log messages
     --skip_log_headers                  If true, avoid headers when opening log files (no effect when -logtostderr=true)
     --stderrthreshold severity          logs at or above this threshold go to stderr when writing to files and stderr (no effect when -logtostderr=true or -alsologtostderr=false) (default 2)
 -v, --v Level                           number for the log level verbosity
     --vmodule moduleSpec                comma-separated list of pattern=N settings for file-filtered logging
     --zap-devel                         Development Mode defaults(encoder=consoleEncoder,logLevel=Debug,stackTraceLevel=Warn). Production Mode defaults(encoder=jsonEncoder,logLevel=Info,stackTraceLevel=Error)
     --zap-encoder encoder               Zap log encoding (one of 'json' or 'console')
     --zap-log-level level               Zap Level to configure the verbosity of logging. Can be one of 'debug', 'info', 'error', or any integer value > 0 which corresponds to custom debug levels of increasing verbosity
     --zap-stacktrace-level level        Zap Level at and above which stacktraces are captured (one of 'info', 'error', 'panic').
     --zap-time-encoding time-encoding   Zap time encoding (one of 'epoch', 'millis', 'nano', 'iso8601', 'rfc3339' or 'rfc3339nano'). Defaults to 'epoch'.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jakobmoellerdev
Copy link
Contributor Author

/hold

If this approach gets general approval I want to add some tests for the added options function

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 5, 2023
@openshift-ci-robot
Copy link

openshift-ci-robot commented Oct 5, 2023 •
edited by openshift-ci bot
Loading

@jakobmoellerdev: This pull request references OCPVE-343 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.15.0" version, but no target version was set.

In response to this:

Allows passing through all log settings for vgmanager, topolvm-controller, topolvm-node and lvmd and all csi-sidecar containers (resizer, snapshotter, external-provisioner, registrar). The flags are passed generically with a prefix that is attached to them and they will only be passed if they differ from the default value. LVMD supports less than usual flags as it uses a legacy logging library from cybozu.

This is the new help with all flags available in the operator:

./bin/lvms operator --help
Operator reconciling LVMCluster LVMVolumeGroup and LVMVolumeGroupNodeStatus

Usage:
 lvms operator [flags]

Flags:
     --csi-sidecar-add_dir_header                           CSI Sidecar: If true, adds the file directory to the header of the log messages
     --csi-sidecar-alsologtostderr                          CSI Sidecar: log to standard error as well as files (no effect when -logtostderr=true)
     --csi-sidecar-log_backtrace_at traceLocation           CSI Sidecar: when logging hits line file:N, emit a stack trace (default :0)
     --csi-sidecar-log_dir string                           CSI Sidecar: If non-empty, write log files in this directory (no effect when -logtostderr=true)
     --csi-sidecar-log_file string                          CSI Sidecar: If non-empty, use this log file (no effect when -logtostderr=true)
     --csi-sidecar-log_file_max_size uint                   CSI Sidecar: Defines the maximum size a log file can grow to (no effect when -logtostderr=true). Unit is megabytes. If the value is 0, the maximum file size is unlimited. (default 1800)
     --csi-sidecar-logtostderr                              CSI Sidecar: log to standard error instead of files (default true)
     --csi-sidecar-one_output                               CSI Sidecar: If true, only write logs to their native severity level (vs also writing to each lower severity level; no effect when -logtostderr=true)
     --csi-sidecar-skip_headers                             CSI Sidecar: If true, avoid header prefixes in the log messages
     --csi-sidecar-skip_log_headers                         CSI Sidecar: If true, avoid headers when opening log files (no effect when -logtostderr=true)
     --csi-sidecar-stderrthreshold severity                 CSI Sidecar: logs at or above this threshold go to stderr when writing to files and stderr (no effect when -logtostderr=true or -alsologtostderr=false) (default 2)
     --csi-sidecar-v Level                                  CSI Sidecar: number for the log level verbosity
     --csi-sidecar-vmodule moduleSpec                       CSI Sidecar: comma-separated list of pattern=N settings for file-filtered logging
     --diagnostics-address string                           The address the diagnostics endpoint binds to. (default ":8443")
     --health-probe-bind-address string                     The address the probe endpoint binds to. (default ":8081")
 -h, --help                                                 help for operator
     --leader-elect                                         Enable leader election for controller manager. Enabling this will ensure there is only one active controller manager.
     --lvmd-logfile string                                  LVMD: Log filename
     --lvmd-logformat string                                LVMD: Log format [plain,logfmt,json]
     --lvmd-loglevel string                                 LVMD: Log level [critical,error,warning,info,debug]
     --topolvm-controller-add_dir_header                    TopoLVM Controller: If true, adds the file directory to the header of the log messages
     --topolvm-controller-alsologtostderr                   TopoLVM Controller: log to standard error as well as files (no effect when -logtostderr=true)
     --topolvm-controller-log_backtrace_at traceLocation    TopoLVM Controller: when logging hits line file:N, emit a stack trace (default :0)
     --topolvm-controller-log_dir string                    TopoLVM Controller: If non-empty, write log files in this directory (no effect when -logtostderr=true)
     --topolvm-controller-log_file string                   TopoLVM Controller: If non-empty, use this log file (no effect when -logtostderr=true)
     --topolvm-controller-log_file_max_size uint            TopoLVM Controller: Defines the maximum size a log file can grow to (no effect when -logtostderr=true). Unit is megabytes. If the value is 0, the maximum file size is unlimited. (default 1800)
     --topolvm-controller-logtostderr                       TopoLVM Controller: log to standard error instead of files (default true)
     --topolvm-controller-one_output                        TopoLVM Controller: If true, only write logs to their native severity level (vs also writing to each lower severity level; no effect when -logtostderr=true)
     --topolvm-controller-skip_headers                      TopoLVM Controller: If true, avoid header prefixes in the log messages
     --topolvm-controller-skip_log_headers                  TopoLVM Controller: If true, avoid headers when opening log files (no effect when -logtostderr=true)
     --topolvm-controller-stderrthreshold severity          TopoLVM Controller: logs at or above this threshold go to stderr when writing to files and stderr (no effect when -logtostderr=true or -alsologtostderr=false) (default 2)
     --topolvm-controller-v Level                           TopoLVM Controller: number for the log level verbosity
     --topolvm-controller-vmodule moduleSpec                TopoLVM Controller: comma-separated list of pattern=N settings for file-filtered logging
     --topolvm-controller-zap-devel                         TopoLVM Controller: Development Mode defaults(encoder=consoleEncoder,logLevel=Debug,stackTraceLevel=Warn). Production Mode defaults(encoder=jsonEncoder,logLevel=Info,stackTraceLevel=Error)
     --topolvm-controller-zap-encoder encoder               TopoLVM Controller: Zap log encoding (one of 'json' or 'console')
     --topolvm-controller-zap-log-level level               TopoLVM Controller: Zap Level to configure the verbosity of logging. Can be one of 'debug', 'info', 'error', or any integer value > 0 which corresponds to custom debug levels of increasing verbosity
     --topolvm-controller-zap-stacktrace-level level        TopoLVM Controller: Zap Level at and above which stacktraces are captured (one of 'info', 'error', 'panic').
     --topolvm-controller-zap-time-encoding time-encoding   TopoLVM Controller: Zap time encoding (one of 'epoch', 'millis', 'nano', 'iso8601', 'rfc3339' or 'rfc3339nano'). Defaults to 'epoch'.
     --topolvm-node-add_dir_header                          TopoLVM Node: If true, adds the file directory to the header of the log messages
     --topolvm-node-alsologtostderr                         TopoLVM Node: log to standard error as well as files (no effect when -logtostderr=true)
     --topolvm-node-log_backtrace_at traceLocation          TopoLVM Node: when logging hits line file:N, emit a stack trace (default :0)
     --topolvm-node-log_dir string                          TopoLVM Node: If non-empty, write log files in this directory (no effect when -logtostderr=true)
     --topolvm-node-log_file string                         TopoLVM Node: If non-empty, use this log file (no effect when -logtostderr=true)
     --topolvm-node-log_file_max_size uint                  TopoLVM Node: Defines the maximum size a log file can grow to (no effect when -logtostderr=true). Unit is megabytes. If the value is 0, the maximum file size is unlimited. (default 1800)
     --topolvm-node-logtostderr                             TopoLVM Node: log to standard error instead of files (default true)
     --topolvm-node-one_output                              TopoLVM Node: If true, only write logs to their native severity level (vs also writing to each lower severity level; no effect when -logtostderr=true)
     --topolvm-node-skip_headers                            TopoLVM Node: If true, avoid header prefixes in the log messages
     --topolvm-node-skip_log_headers                        TopoLVM Node: If true, avoid headers when opening log files (no effect when -logtostderr=true)
     --topolvm-node-stderrthreshold severity                TopoLVM Node: logs at or above this threshold go to stderr when writing to files and stderr (no effect when -logtostderr=true or -alsologtostderr=false) (default 2)
     --topolvm-node-v Level                                 TopoLVM Node: number for the log level verbosity
     --topolvm-node-vmodule moduleSpec                      TopoLVM Node: comma-separated list of pattern=N settings for file-filtered logging
     --topolvm-node-zap-devel                               TopoLVM Node: Development Mode defaults(encoder=consoleEncoder,logLevel=Debug,stackTraceLevel=Warn). Production Mode defaults(encoder=jsonEncoder,logLevel=Info,stackTraceLevel=Error)
     --topolvm-node-zap-encoder encoder                     TopoLVM Node: Zap log encoding (one of 'json' or 'console')
     --topolvm-node-zap-log-level level                     TopoLVM Node: Zap Level to configure the verbosity of logging. Can be one of 'debug', 'info', 'error', or any integer value > 0 which corresponds to custom debug levels of increasing verbosity
     --topolvm-node-zap-stacktrace-level level              TopoLVM Node: Zap Level at and above which stacktraces are captured (one of 'info', 'error', 'panic').
     --topolvm-node-zap-time-encoding time-encoding         TopoLVM Node: Zap time encoding (one of 'epoch', 'millis', 'nano', 'iso8601', 'rfc3339' or 'rfc3339nano'). Defaults to 'epoch'.
     --vgmanager-add_dir_header                             vgmanager: If true, adds the file directory to the header of the log messages
     --vgmanager-alsologtostderr                            vgmanager: log to standard error as well as files (no effect when -logtostderr=true)
     --vgmanager-cmd strings                                The command that should be used to start vgmanager on the node. Useful for debugging purposes but normally not changed. (default [/lvms,vgmanager])
     --vgmanager-log_backtrace_at traceLocation             vgmanager: when logging hits line file:N, emit a stack trace (default :0)
     --vgmanager-log_dir string                             vgmanager: If non-empty, write log files in this directory (no effect when -logtostderr=true)
     --vgmanager-log_file string                            vgmanager: If non-empty, use this log file (no effect when -logtostderr=true)
     --vgmanager-log_file_max_size uint                     vgmanager: Defines the maximum size a log file can grow to (no effect when -logtostderr=true). Unit is megabytes. If the value is 0, the maximum file size is unlimited. (default 1800)
     --vgmanager-logtostderr                                vgmanager: log to standard error instead of files (default true)
     --vgmanager-one_output                                 vgmanager: If true, only write logs to their native severity level (vs also writing to each lower severity level; no effect when -logtostderr=true)
     --vgmanager-skip_headers                               vgmanager: If true, avoid header prefixes in the log messages
     --vgmanager-skip_log_headers                           vgmanager: If true, avoid headers when opening log files (no effect when -logtostderr=true)
     --vgmanager-stderrthreshold severity                   vgmanager: logs at or above this threshold go to stderr when writing to files and stderr (no effect when -logtostderr=true or -alsologtostderr=false) (default 2)
     --vgmanager-v Level                                    vgmanager: number for the log level verbosity
     --vgmanager-vmodule moduleSpec                         vgmanager: comma-separated list of pattern=N settings for file-filtered logging
     --vgmanager-zap-devel                                  vgmanager: Development Mode defaults(encoder=consoleEncoder,logLevel=Debug,stackTraceLevel=Warn). Production Mode defaults(encoder=jsonEncoder,logLevel=Info,stackTraceLevel=Error)
     --vgmanager-zap-encoder encoder                        vgmanager: Zap log encoding (one of 'json' or 'console')
     --vgmanager-zap-log-level level                        vgmanager: Zap Level to configure the verbosity of logging. Can be one of 'debug', 'info', 'error', or any integer value > 0 which corresponds to custom debug levels of increasing verbosity
     --vgmanager-zap-stacktrace-level level                 vgmanager: Zap Level at and above which stacktraces are captured (one of 'info', 'error', 'panic').
     --vgmanager-zap-time-encoding time-encoding            vgmanager: Zap time encoding (one of 'epoch', 'millis', 'nano', 'iso8601', 'rfc3339' or 'rfc3339nano'). Defaults to 'epoch'.

Global Flags:
     --add_dir_header                    If true, adds the file directory to the header of the log messages
     --alsologtostderr                   log to standard error as well as files (no effect when -logtostderr=true)
     --log_backtrace_at traceLocation    when logging hits line file:N, emit a stack trace (default :0)
     --log_dir string                    If non-empty, write log files in this directory (no effect when -logtostderr=true)
     --log_file string                   If non-empty, use this log file (no effect when -logtostderr=true)
     --log_file_max_size uint            Defines the maximum size a log file can grow to (no effect when -logtostderr=true). Unit is megabytes. If the value is 0, the maximum file size is unlimited. (default 1800)
     --logfile string                    Log filename
     --logformat string                  Log format [plain,logfmt,json]
     --loglevel string                   Log level [critical,error,warning,info,debug]
     --logtostderr                       log to standard error instead of files (default true)
     --one_output                        If true, only write logs to their native severity level (vs also writing to each lower severity level; no effect when -logtostderr=true)
     --skip_headers                      If true, avoid header prefixes in the log messages
     --skip_log_headers                  If true, avoid headers when opening log files (no effect when -logtostderr=true)
     --stderrthreshold severity          logs at or above this threshold go to stderr when writing to files and stderr (no effect when -logtostderr=true or -alsologtostderr=false) (default 2)
 -v, --v Level                           number for the log level verbosity
     --vmodule moduleSpec                comma-separated list of pattern=N settings for file-filtered logging
     --zap-devel                         Development Mode defaults(encoder=consoleEncoder,logLevel=Debug,stackTraceLevel=Warn). Production Mode defaults(encoder=jsonEncoder,logLevel=Info,stackTraceLevel=Error)
     --zap-encoder encoder               Zap log encoding (one of 'json' or 'console')
     --zap-log-level level               Zap Level to configure the verbosity of logging. Can be one of 'debug', 'info', 'error', or any integer value > 0 which corresponds to custom debug levels of increasing verbosity
     --zap-stacktrace-level level        Zap Level at and above which stacktraces are captured (one of 'info', 'error', 'panic').
     --zap-time-encoding time-encoding   Zap time encoding (one of 'epoch', 'millis', 'nano', 'iso8601', 'rfc3339' or 'rfc3339nano'). Defaults to 'epoch'.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jakobmoellerdev jakobmoellerdev force-pushed the OCPVE-343-log-passthrough branch 2 times, most recently from aae0f68 to 193e6b4 Compare October 6, 2023 07:14
@codecov-commenter
Copy link

codecov-commenter commented Oct 6, 2023 •
edited
Loading

Codecov Report

Merging #440 (cdec260) into main (b805863) will increase coverage by 1.75%.
Report is 2 commits behind head on main.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #440      +/-   ##
==========================================
+ Coverage   57.65%   59.41%   +1.75%     
==========================================
  Files          20       21       +1     
  Lines        1547     1614      +67     
==========================================
+ Hits          892      959      +67     
  Misses        539      539              
  Partials      116      116
Files Coverage Δ
...l/controllers/lvmcluster/logpassthrough/options.go 100.00% <100.00%> (ø)
...al/controllers/lvmcluster/lvmcluster_controller.go 62.98% <100.00%> (+0.35%) ⬆️

@jakobmoellerdev
Copy link
Contributor Author

/test lvm-operator-e2e-aws-sno

@openshift-ci-robot
Copy link

openshift-ci-robot commented Oct 6, 2023 •
edited by openshift-ci bot
Loading

@jakobmoellerdev: This pull request references OCPVE-343 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.15.0" version, but no target version was set.

In response to this:

Allows passing through all log settings for vgmanager, topolvm-controller, topolvm-node and lvmd and all csi-sidecar containers (resizer, snapshotter, external-provisioner, registrar). The flags are passed generically with a prefix that is attached to them and they will only be passed if they differ from the default value. LVMD supports less than usual flags as it uses a legacy logging library from cybozu.

This is the new help with all flags available in the operator:

./bin/lvms operator --help
Operator reconciling LVMCluster LVMVolumeGroup and LVMVolumeGroupNodeStatus

Usage:
 lvms operator [flags]

Flags:
     --csi-sidecar-v string                      csi-sidecar: number for the log level verbosity
     --csi-sidecar-vmodule string                csi-sidecar: comma-separated list of pattern=N settings for file-filtered logging
     --diagnostics-address string                The address the diagnostics endpoint binds to. (default ":8443")
     --health-probe-bind-address string          The address the probe endpoint binds to. (default ":8081")
 -h, --help                                      help for operator
     --leader-elect                              Enable leader election for controller manager. Enabling this will ensure there is only one active controller manager.
     --lvmd-loglevel string                      Log level [critical,error,warning,info,debug]
     --topolvm-controller-v string               topolvm-controller: number for the log level verbosity
     --topolvm-controller-vmodule string         topolvm-controller: comma-separated list of pattern=N settings for file-filtered logging
     --topolvm-controller-zap-log-level string   topolvm-controller: Zap Level to configure the verbosity of logging. Can be one of 'debug', 'info', 'error', or any integer value > 0 which corresponds to custom debug levels of increasing verbosity
     --topolvm-node-v string                     topolvm-node: number for the log level verbosity
     --topolvm-node-vmodule string               topolvm-node: comma-separated list of pattern=N settings for file-filtered logging
     --topolvm-node-zap-log-level string         topolvm-node: Zap Level to configure the verbosity of logging. Can be one of 'debug', 'info', 'error', or any integer value > 0 which corresponds to custom debug levels of increasing verbosity
     --vgmanager-cmd strings                     The command that should be used to start vgmanager on the node. Useful for debugging purposes but normally not changed. (default [/lvms,vgmanager])
     --vgmanager-v string                        vgmanager: number for the log level verbosity
     --vgmanager-vmodule string                  vgmanager: comma-separated list of pattern=N settings for file-filtered logging
     --vgmanager-zap-log-level string            vgmanager: Zap Level to configure the verbosity of logging. Can be one of 'debug', 'info', 'error', or any integer value > 0 which corresponds to custom debug levels of increasing verbosity

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Oct 6, 2023 •
edited by openshift-ci bot
Loading

@jakobmoellerdev: This pull request references OCPVE-343 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.15.0" version, but no target version was set.

In response to this:

Allows passing through log verbosity settings for vgmanager, topolvm-controller, topolvm-node and lvmd and all csi-sidecar containers (resizer, snapshotter, external-provisioner, registrar). The flags are passed generically with a prefix that is attached to them and they will only be passed if they differ from the default value. LVMD supports less than usual flags as it uses a legacy logging library from cybozu.

This is the new help with all flags available in the operator:

./bin/lvms operator --help
Operator reconciling LVMCluster LVMVolumeGroup and LVMVolumeGroupNodeStatus

Usage:
 lvms operator [flags]

Flags:
     --csi-sidecar-v string                      csi-sidecar: number for the log level verbosity
     --csi-sidecar-vmodule string                csi-sidecar: comma-separated list of pattern=N settings for file-filtered logging
     --diagnostics-address string                The address the diagnostics endpoint binds to. (default ":8443")
     --health-probe-bind-address string          The address the probe endpoint binds to. (default ":8081")
 -h, --help                                      help for operator
     --leader-elect                              Enable leader election for controller manager. Enabling this will ensure there is only one active controller manager.
     --lvmd-loglevel string                      Log level [critical,error,warning,info,debug]
     --topolvm-controller-v string               topolvm-controller: number for the log level verbosity
     --topolvm-controller-vmodule string         topolvm-controller: comma-separated list of pattern=N settings for file-filtered logging
     --topolvm-controller-zap-log-level string   topolvm-controller: Zap Level to configure the verbosity of logging. Can be one of 'debug', 'info', 'error', or any integer value > 0 which corresponds to custom debug levels of increasing verbosity
     --topolvm-node-v string                     topolvm-node: number for the log level verbosity
     --topolvm-node-vmodule string               topolvm-node: comma-separated list of pattern=N settings for file-filtered logging
     --topolvm-node-zap-log-level string         topolvm-node: Zap Level to configure the verbosity of logging. Can be one of 'debug', 'info', 'error', or any integer value > 0 which corresponds to custom debug levels of increasing verbosity
     --vgmanager-cmd strings                     The command that should be used to start vgmanager on the node. Useful for debugging purposes but normally not changed. (default [/lvms,vgmanager])
     --vgmanager-v string                        vgmanager: number for the log level verbosity
     --vgmanager-vmodule string                  vgmanager: comma-separated list of pattern=N settings for file-filtered logging
     --vgmanager-zap-log-level string            vgmanager: Zap Level to configure the verbosity of logging. Can be one of 'debug', 'info', 'error', or any integer value > 0 which corresponds to custom debug levels of increasing verbosity

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jakobmoellerdev
feat: allow passthrough for log flags
d718f6d 
Signed-off-by: Jakob Möller <jmoller@redhat.com>
@jakobmoellerdev
Copy link
Contributor Author

/unhold

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 6, 2023
@openshift-ci-robot
Copy link

openshift-ci-robot commented Oct 6, 2023 •
edited by openshift-ci bot
Loading

@jakobmoellerdev: This pull request references OCPVE-343 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.15.0" version, but no target version was set.

In response to this:

Allows passing through log verbosity settings for vgmanager, topolvm-controller, topolvm-node and lvmd and all csi-sidecar containers (resizer, snapshotter, external-provisioner, registrar). The flags are passed generically with a prefix that is attached to them and they will only be passed if they differ from the default value. LVMD supports less than usual flags as it uses a legacy logging library from cybozu.

This is the new help with all flags available in the operator:

./bin/lvms operator --help
Operator reconciling LVMCluster LVMVolumeGroup and LVMVolumeGroupNodeStatus

Usage:
 lvms operator [flags]

Flags:
     --csi-sidecar-v string                      csi-sidecar: number for the log level verbosity
     --csi-sidecar-vmodule string                csi-sidecar: comma-separated list of pattern=N settings for file-filtered logging
     --diagnostics-address string                The address the diagnostics endpoint binds to. (default ":8443")
     --health-probe-bind-address string          The address the probe endpoint binds to. (default ":8081")
 -h, --help                                      help for operator
     --leader-elect                              Enable leader election for controller manager. Enabling this will ensure there is only one active controller manager.
     --lvmd-loglevel string                      Log level [critical,error,warning,info,debug]
     --topolvm-controller-v string               topolvm-controller: number for the log level verbosity
     --topolvm-controller-vmodule string         topolvm-controller: comma-separated list of pattern=N settings for file-filtered logging
     --topolvm-controller-zap-log-level string   topolvm-controller: Zap Level to configure the verbosity of logging. Can be one of 'debug', 'info', 'error', or any integer value > 0 which corresponds to custom debug levels of increasing verbosity
     --topolvm-node-v string                     topolvm-node: number for the log level verbosity
     --topolvm-node-vmodule string               topolvm-node: comma-separated list of pattern=N settings for file-filtered logging
     --topolvm-node-zap-log-level string         topolvm-node: Zap Level to configure the verbosity of logging. Can be one of 'debug', 'info', 'error', or any integer value > 0 which corresponds to custom debug levels of increasing verbosity
     --vgmanager-cmd strings                     The command that should be used to start vgmanager on the node. Useful for debugging purposes but normally not changed. (default [/lvms,vgmanager])
     --vgmanager-v string                        vgmanager: number for the log level verbosity
     --vgmanager-vmodule string                  vgmanager: comma-separated list of pattern=N settings for file-filtered logging
     --vgmanager-zap-log-level string            vgmanager: Zap Level to configure the verbosity of logging. Can be one of 'debug', 'info', 'error', or any integer value > 0 which corresponds to custom debug levels of increasing verbosity

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@suleymanakbas91
Copy link
Contributor

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 6, 2023
@openshift-ci-robot
Copy link

openshift-ci-robot commented Oct 6, 2023 •
edited by openshift-ci bot
Loading

@jakobmoellerdev: This pull request references OCPVE-343 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.15.0" version, but it targets "openshift-4.15" instead.

In response to this:

Allows passing through log verbosity settings for vgmanager, topolvm-controller, topolvm-node and lvmd and all csi-sidecar containers (resizer, snapshotter, external-provisioner, registrar). The flags are passed generically with a prefix that is attached to them and they will only be passed if they differ from the default value. LVMD supports less than usual flags as it uses a legacy logging library from cybozu.

This is the new help with all flags available in the operator:

./bin/lvms operator --help
Operator reconciling LVMCluster LVMVolumeGroup and LVMVolumeGroupNodeStatus

Usage:
 lvms operator [flags]

Flags:
     --csi-sidecar-v string                      csi-sidecar: number for the log level verbosity
     --csi-sidecar-vmodule string                csi-sidecar: comma-separated list of pattern=N settings for file-filtered logging
     --diagnostics-address string                The address the diagnostics endpoint binds to. (default ":8443")
     --health-probe-bind-address string          The address the probe endpoint binds to. (default ":8081")
 -h, --help                                      help for operator
     --leader-elect                              Enable leader election for controller manager. Enabling this will ensure there is only one active controller manager.
     --lvmd-loglevel string                      Log level [critical,error,warning,info,debug]
     --topolvm-controller-v string               topolvm-controller: number for the log level verbosity
     --topolvm-controller-vmodule string         topolvm-controller: comma-separated list of pattern=N settings for file-filtered logging
     --topolvm-controller-zap-log-level string   topolvm-controller: Zap Level to configure the verbosity of logging. Can be one of 'debug', 'info', 'error', or any integer value > 0 which corresponds to custom debug levels of increasing verbosity
     --topolvm-node-v string                     topolvm-node: number for the log level verbosity
     --topolvm-node-vmodule string               topolvm-node: comma-separated list of pattern=N settings for file-filtered logging
     --topolvm-node-zap-log-level string         topolvm-node: Zap Level to configure the verbosity of logging. Can be one of 'debug', 'info', 'error', or any integer value > 0 which corresponds to custom debug levels of increasing verbosity
     --vgmanager-cmd strings                     The command that should be used to start vgmanager on the node. Useful for debugging purposes but normally not changed. (default [/lvms,vgmanager])
     --vgmanager-v string                        vgmanager: number for the log level verbosity
     --vgmanager-vmodule string                  vgmanager: comma-separated list of pattern=N settings for file-filtered logging
     --vgmanager-zap-log-level string            vgmanager: Zap Level to configure the verbosity of logging. Can be one of 'debug', 'info', 'error', or any integer value > 0 which corresponds to custom debug levels of increasing verbosity

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 6, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jakobmoellerdev, suleymanakbas91

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 6, 2023
@openshift-ci-robot
Copy link

openshift-ci-robot commented Oct 6, 2023 •
edited by openshift-ci bot
Loading

@jakobmoellerdev: This pull request references OCPVE-343 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.15.0" version, but it targets "openshift-4.15" instead.

In response to this:

Allows passing through log verbosity settings for vgmanager, topolvm-controller, topolvm-node and lvmd and all csi-sidecar containers (resizer, snapshotter, external-provisioner, registrar). The flags are passed generically with a prefix that is attached to them and they will only be passed if they differ from the default value. LVMD supports less than usual flags as it uses a legacy logging library from cybozu.

This is the new help with all flags available in the operator:

./bin/lvms operator --help
Operator reconciling LVMCluster LVMVolumeGroup and LVMVolumeGroupNodeStatus

Usage:
 lvms operator [flags]

Flags:
     --csi-sidecar-v string                      csi-sidecar: number for the log level verbosity
     --csi-sidecar-vmodule string                csi-sidecar: comma-separated list of pattern=N settings for file-filtered logging
     --diagnostics-address string                The address the diagnostics endpoint binds to. (default ":8443")
     --health-probe-bind-address string          The address the probe endpoint binds to. (default ":8081")
 -h, --help                                      help for operator
     --leader-elect                              Enable leader election for controller manager. Enabling this will ensure there is only one active controller manager.
     --lvmd-loglevel string                      Log level [critical,error,warning,info,debug]
     --topolvm-controller-v string               topolvm-controller: number for the log level verbosity
     --topolvm-controller-vmodule string         topolvm-controller: comma-separated list of pattern=N settings for file-filtered logging
     --topolvm-controller-zap-log-level string   topolvm-controller: Zap Level to configure the verbosity of logging. Can be one of 'debug', 'info', 'error', or any integer value > 0 which corresponds to custom debug levels of increasing verbosity
     --topolvm-node-v string                     topolvm-node: number for the log level verbosity
     --topolvm-node-vmodule string               topolvm-node: comma-separated list of pattern=N settings for file-filtered logging
     --topolvm-node-zap-log-level string         topolvm-node: Zap Level to configure the verbosity of logging. Can be one of 'debug', 'info', 'error', or any integer value > 0 which corresponds to custom debug levels of increasing verbosity
     --vgmanager-cmd strings                     The command that should be used to start vgmanager on the node. Useful for debugging purposes but normally not changed. (default [/lvms,vgmanager])
     --vgmanager-v string                        vgmanager: number for the log level verbosity
     --vgmanager-vmodule string                  vgmanager: comma-separated list of pattern=N settings for file-filtered logging
     --vgmanager-zap-log-level string            vgmanager: Zap Level to configure the verbosity of logging. Can be one of 'debug', 'info', 'error', or any integer value > 0 which corresponds to custom debug levels of increasing verbosity

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 6, 2023

@jakobmoellerdev: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-ci openshift-ci bot merged commit 58e7c6f into openshift:main Oct 6, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brandisher brandisher Awaiting requested review from brandisher

@qJkee qJkee Awaiting requested review from qJkee

Assignees

@suleymanakbas91 suleymanakbas91

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jakobmoellerdev @openshift-ci-robot @codecov-commenter @suleymanakbas91