OCPVE-709: feat: allow dlv debugging for lvm operator and vgmanager

[jakobmoellerdev]

Introduces a new flag to pass the command to the created vg manager daemonset and introduces two new make targets: docker-build-debug and deploy-debug which use a delve enabled dockerfile that allows remote attachment in the cluster for debugging purposes.

One can attach to the application by running a port-forward to either lvm-operator or vgmanager on port 2345. Then one can remotely attach the debugger as per https://www.jetbrains.com/help/go/attach-to-running-go-processes-with-debugger.html#step-3-create-the-remote-run-debug-configuration-on-the-client-computer or https://github.com/golang/vscode-go/blob/master/docs/debugging.md#connect-to-headless-delve-with-target-specified-at-server-start-up

[openshift-ci-robot]

@jakobmoellerdev: This pull request references OCPVE-709 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.15.0" version, but no target version was set.

In response to this:

Introduces a new flag to pass the command to the created vg manager daemonset and introduces two new make targets: docker-build-debug and deploy-debug which use a delve enabled dockerfile that allows remote attachment in the cluster for debugging purposes.

One can attach to the application by running a port-forward to either lvm-operator or vgmanager on port 2345. Then one can remotely attach the debugger as per https://www.jetbrains.com/help/go/attach-to-running-go-processes-with-debugger.html#step-3-create-the-remote-run-debug-configuration-on-the-client-computer or https://github.com/golang/vscode-go/blob/master/docs/debugging.md#connect-to-headless-delve-with-target-specified-at-server-start-up

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-ci-robot]

@jakobmoellerdev: This pull request references OCPVE-709 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.15.0" version, but no target version was set.

In response to this:

Introduces a new flag to pass the command to the created vg manager daemonset and introduces two new make targets: docker-build-debug and deploy-debug which use a delve enabled dockerfile that allows remote attachment in the cluster for debugging purposes.

One can attach to the application by running a port-forward to either lvm-operator or vgmanager on port 2345. Then one can remotely attach the debugger as per https://www.jetbrains.com/help/go/attach-to-running-go-processes-with-debugger.html#step-3-create-the-remote-run-debug-configuration-on-the-client-computer or https://github.com/golang/vscode-go/blob/master/docs/debugging.md#connect-to-headless-delve-with-target-specified-at-server-start-up

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[codecov-commenter]

Codecov Report

Merging #438 (c594895) into main (5e45008) will increase coverage by 0.05%.
The diff coverage is 100.00%.

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #438      +/-   ##
==========================================
+ Coverage   57.60%   57.65%   +0.05%     
==========================================
  Files          20       20              
  Lines        1545     1547       +2     
==========================================
+ Hits          890      892       +2     
  Misses        539      539              
  Partials      116      116              

Files	Coverage Δ
...al/controllers/lvmcluster/lvmcluster_controller.go	62.62% <100.00%> (+0.36%)	⬆️

[jakobmoellerdev]

/test lvm-operator-e2e-aws-sno

[suleymanakbas91]

It looks pretty good in general. Just a few nits, it's missing documentation.

[openshift-ci]

@jakobmoellerdev: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[suleymanakbas91]

/lgtm
/approve

[openshift-ci-robot]

@jakobmoellerdev: This pull request references OCPVE-709 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.15.0" version, but no target version was set.

In response to this:

Introduces a new flag to pass the command to the created vg manager daemonset and introduces two new make targets: docker-build-debug and deploy-debug which use a delve enabled dockerfile that allows remote attachment in the cluster for debugging purposes.

One can attach to the application by running a port-forward to either lvm-operator or vgmanager on port 2345. Then one can remotely attach the debugger as per https://www.jetbrains.com/help/go/attach-to-running-go-processes-with-debugger.html#step-3-create-the-remote-run-debug-configuration-on-the-client-computer or https://github.com/golang/vscode-go/blob/master/docs/debugging.md#connect-to-headless-delve-with-target-specified-at-server-start-up

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jakobmoellerdev, suleymanakbas91

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [suleymanakbas91]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci-robot]

@jakobmoellerdev: This pull request references OCPVE-709 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.15.0" version, but no target version was set.

In response to this:

Introduces a new flag to pass the command to the created vg manager daemonset and introduces two new make targets: docker-build-debug and deploy-debug which use a delve enabled dockerfile that allows remote attachment in the cluster for debugging purposes.

One can attach to the application by running a port-forward to either lvm-operator or vgmanager on port 2345. Then one can remotely attach the debugger as per https://www.jetbrains.com/help/go/attach-to-running-go-processes-with-debugger.html#step-3-create-the-remote-run-debug-configuration-on-the-client-computer or https://github.com/golang/vscode-go/blob/master/docs/debugging.md#connect-to-headless-delve-with-target-specified-at-server-start-up

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.