Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCPVE-677: chore: separate device filtering from vgmanager in lsblk package #415

Merged

Conversation

jakobmoellerdev
Copy link
Contributor

@jakobmoellerdev jakobmoellerdev commented Sep 11, 2023

Part of vgmanager Refactor.

Refactored vgmanager to use the lsblk and filter package for discovering and filtering block devices. This change involves updating the types, function calls, and unit tests to use the types and functions provided by the lsblk package.

@jakobmoellerdev jakobmoellerdev changed the title chore: separate device filtering from vgmanager in lsblk package OCPVE-677: chore: separate device filtering from vgmanager in lsblk package Sep 11, 2023
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Sep 11, 2023
@openshift-ci-robot
Copy link

openshift-ci-robot commented Sep 11, 2023

@jakobmoellerdev: This pull request references OCPVE-677 which is a valid jira issue.

In response to this:

Part of vgmanager Refactor.

Refactored the lvm-operator to use the lsblk and filter package for discovering and filtering block devices. This change involves updating the types, function calls, and unit tests to use the types and functions provided by the lsblk package.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Sep 11, 2023
@openshift-ci-robot
Copy link

openshift-ci-robot commented Sep 11, 2023

@jakobmoellerdev: This pull request references OCPVE-677 which is a valid jira issue.

In response to this:

Part of vgmanager Refactor.

Refactored vgmanager to use the lsblk and filter package for discovering and filtering block devices. This change involves updating the types, function calls, and unit tests to use the types and functions provided by the lsblk package.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@codecov-commenter
Copy link

codecov-commenter commented Sep 11, 2023

Codecov Report

Merging #415 (3407add) into main (8a0a648) will increase coverage by 0.03%.
The diff coverage is 59.25%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #415      +/-   ##
==========================================
+ Coverage   54.07%   54.11%   +0.03%     
==========================================
  Files          27       27              
  Lines        2358     2360       +2     
==========================================
+ Hits         1275     1277       +2     
  Misses        997      997              
  Partials       86       86              
Files Changed Coverage Δ
pkg/vgmanager/vgmanager_controller.go 10.00% <0.00%> (ø)
pkg/lvm/lvm.go 38.25% <37.50%> (ø)
pkg/filter/filter.go 62.74% <62.00%> (+1.52%) ⬆️
pkg/vgmanager/devices.go 75.78% <84.61%> (ø)

@suleymanakbas91
Copy link
Contributor

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 11, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 11, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jakobmoellerdev, suleymanakbas91

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 11, 2023
@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 554d501 and 2 for PR HEAD a28a369 in total

@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Sep 11, 2023
@suleymanakbas91
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 11, 2023
@jakobmoellerdev
Copy link
Contributor Author

/test lvm-operator-e2e-aws-sno

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 11, 2023

@jakobmoellerdev: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit d147fcb into openshift:main Sep 11, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants