Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCPVE-677: fix: allow deleting all storageclasses / vgs in case one is already gone #414

Conversation

jakobmoellerdev
Copy link
Contributor

Part of vgmanager refactor. For resourceManagers managing multiple resources, previously the delete aborted if one of the managed resources was not found. Now it properly continues until all resources are no longer found. This applies to LVMVolumeGroup, SCCs, VolumeSnapshotClass and StorageClass

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Sep 8, 2023
@openshift-ci-robot
Copy link

openshift-ci-robot commented Sep 8, 2023

@jakobmoellerdev: This pull request references OCPVE-677 which is a valid jira issue.

In response to this:

Part of vgmanager refactor. For resourceManagers managing multiple resources, previously the delete aborted if one of the managed resources was not found. Now it properly continues until all resources are no longer found. This applies to LVMVolumeGroup, SCCs, VolumeSnapshotClass and StorageClass

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Sep 8, 2023
@codecov-commenter
Copy link

codecov-commenter commented Sep 8, 2023

Codecov Report

Merging #414 (2b1d98c) into main (8da92ee) will decrease coverage by 2.81%.
Report is 10 commits behind head on main.
The diff coverage is 53.84%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #414      +/-   ##
==========================================
- Coverage   55.01%   52.21%   -2.81%     
==========================================
  Files          27       29       +2     
  Lines        2341     2848     +507     
==========================================
+ Hits         1288     1487     +199     
- Misses        965     1261     +296     
- Partials       88      100      +12     
Files Changed Coverage Δ
controllers/scc.go 0.00% <0.00%> (ø)
controllers/topolvm_snapshotclass.go 82.92% <66.66%> (-1.69%) ⬇️
controllers/topolvm_storageclass.go 84.28% <66.66%> (-1.01%) ⬇️
controllers/lvm_volumegroup.go 84.04% <75.00%> (+2.35%) ⬆️

... and 6 files with indirect coverage changes

@jakobmoellerdev
Copy link
Contributor Author

/retest-required

@jakobmoellerdev
Copy link
Contributor Author

/test lvm-operator-e2e-aws

@suleymanakbas91
Copy link
Contributor

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 11, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 11, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jakobmoellerdev, suleymanakbas91

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 11, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 11, 2023

@jakobmoellerdev: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit 554d501 into openshift:main Sep 11, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants