Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCPVE-663: feat: introduce k8s events to lvmcluster and vgmanager #403

Conversation

jakobmoellerdev
Copy link
Contributor

This introduces event recorders to the lvm cluster controller as well as vg manager and issues events on the most important events and failures related to these resources.

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 31, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 31, 2023

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci openshift-ci bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Aug 31, 2023
@jakobmoellerdev
Copy link
Contributor Author

/test all

@jakobmoellerdev jakobmoellerdev changed the title feat: introduce k8s events to lvmcluster and vgmanager OCPVE-663: feat: introduce k8s events to lvmcluster and vgmanager Aug 31, 2023
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Aug 31, 2023
@openshift-ci-robot
Copy link

openshift-ci-robot commented Aug 31, 2023

@jakobmoellerdev: This pull request references OCPVE-663 which is a valid jira issue.

In response to this:

This introduces event recorders to the lvm cluster controller as well as vg manager and issues events on the most important events and failures related to these resources.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jakobmoellerdev jakobmoellerdev force-pushed the OCPVE-663-event-logging branch 7 times, most recently from 05e6743 to 0656b5c Compare August 31, 2023 12:44
@jakobmoellerdev
Copy link
Contributor Author

/test all

@codecov-commenter
Copy link

codecov-commenter commented Aug 31, 2023

Codecov Report

Merging #403 (a61892a) into main (dd8b3b7) will decrease coverage by 1.62%.
The diff coverage is 9.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #403      +/-   ##
==========================================
- Coverage   57.07%   55.46%   -1.62%     
==========================================
  Files          27       27              
  Lines        2169     2241      +72     
==========================================
+ Hits         1238     1243       +5     
- Misses        846      913      +67     
  Partials       85       85              
Files Changed Coverage Δ
controllers/utils.go 45.09% <0.00%> (ø)
pkg/vgmanager/status.go 0.00% <0.00%> (ø)
pkg/vgmanager/vgmanager_controller.go 9.66% <0.00%> (-2.10%) ⬇️
controllers/lvmcluster_controller.go 61.97% <47.61%> (-1.01%) ⬇️

@jakobmoellerdev
Copy link
Contributor Author

/test lvm-operator-e2e-aws

1 similar comment
@jakobmoellerdev
Copy link
Contributor Author

/test lvm-operator-e2e-aws

@jakobmoellerdev jakobmoellerdev marked this pull request as ready for review August 31, 2023 14:04
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 31, 2023
@jakobmoellerdev jakobmoellerdev force-pushed the OCPVE-663-event-logging branch 2 times, most recently from 7f6a0a1 to a61892a Compare August 31, 2023 15:14
@jakobmoellerdev
Copy link
Contributor Author

/test lvm-operator-e2e-aws-sno

controllers/utils.go Outdated Show resolved Hide resolved
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 1, 2023

@jakobmoellerdev: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@suleymanakbas91
Copy link
Contributor

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 7, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 7, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jakobmoellerdev, suleymanakbas91

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 7, 2023
@openshift-merge-robot openshift-merge-robot merged commit 62ff860 into openshift:main Sep 7, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants