Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCPVE-588: chore: adjust e2e makefile / remove e2e-test #393

Conversation

jakobmoellerdev
Copy link
Contributor

removes the old e2e-test target and adjusts the e2e target to use all relevant flags again.

also changes the defaults to not install / uninstall the operator

@openshift-ci openshift-ci bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Aug 22, 2023
@jakobmoellerdev jakobmoellerdev changed the title chore: adjust e2e makefile / remove e2e-test OCPVE-588: chore: adjust e2e makefile / remove e2e-test Aug 22, 2023
@openshift-ci-robot
Copy link

openshift-ci-robot commented Aug 22, 2023

@jakobmoellerdev: This pull request references OCPVE-588 which is a valid jira issue.

In response to this:

removes the old e2e-test target and adjusts the e2e target to use all relevant flags again.

also changes the defaults to not install / uninstall the operator

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Aug 22, 2023
@jakobmoellerdev
Copy link
Contributor Author

/test lvm-operator-e2e-aws

1 similar comment
@jakobmoellerdev
Copy link
Contributor Author

/test lvm-operator-e2e-aws

Copy link
Contributor

@suleymanakbas91 suleymanakbas91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 23, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 23, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jakobmoellerdev, suleymanakbas91

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 23, 2023
@codecov-commenter
Copy link

Codecov Report

Merging #393 (610c523) into main (a962b90) will increase coverage by 40.06%.
Report is 30 commits behind head on main.
The diff coverage is 68.65%.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             main     #393       +/-   ##
===========================================
+ Coverage   16.59%   56.65%   +40.06%     
===========================================
  Files          24       26        +2     
  Lines        2061     2245      +184     
===========================================
+ Hits          342     1272      +930     
+ Misses       1693      883      -810     
- Partials       26       90       +64     
Files Changed Coverage Δ
controllers/lvmcluster_controller_watches.go 90.32% <ø> (+90.32%) ⬆️
pkg/vgmanager/lvm.go 52.03% <ø> (+4.06%) ⬆️
controllers/topolvm_snapshotclass.go 61.22% <14.28%> (+61.22%) ⬆️
pkg/vgmanager/vgmanager_controller.go 10.40% <48.43%> (+10.40%) ⬆️
controllers/lvmcluster_controller.go 58.63% <50.00%> (+58.63%) ⬆️
pkg/cluster/leaderelection.go 66.66% <66.66%> (ø)
pkg/cluster/sno.go 72.72% <72.72%> (ø)
controllers/persistent-volume-claim/controller.go 60.29% <75.00%> (+19.71%) ⬆️
pkg/vgmanager/lv_attr.go 92.59% <92.59%> (ø)
pkg/vgmanager/devices.go 76.80% <95.00%> (+2.60%) ⬆️
... and 1 more

... and 7 files with indirect coverage changes

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 23, 2023

@jakobmoellerdev: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit aebdf45 into openshift:main Aug 23, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants