Merge pull request #612 from suleymanakbas91/ready-check

OCPBUGS-30830: Accommodate the case in readiness calculation where readyVGCount is greater than expectedVGCount
openshift · Apr 23, 2024 · 08da58f · 08da58f
2 parents 7a7d364 + 33c158b
commit 08da58f
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/internal/controllers/lvmcluster/controller.go b/internal/controllers/lvmcluster/controller.go
@@ -310,7 +310,7 @@ func (r *Reconciler) updateLVMClusterStatus(ctx context.Context, instance *lvmv1
 		instance.Status.State = lvmv1alpha1.LVMStatusFailed
 	} else if isDegraded {
 		instance.Status.State = lvmv1alpha1.LVMStatusDegraded
-	} else if isReady && expectedVGCount == readyVGCount {
+	} else if isReady && expectedVGCount <= readyVGCount { // readyVGCount can be greater than expectedVGCount in case there are taints on some nodes, e.g. during an upgrade. See https://issues.redhat.com/browse/OCPBUGS-30830 for further details.
 		instance.Status.State = lvmv1alpha1.LVMStatusReady
 		instance.Status.Ready = true
 	}