Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LOG-5617: Use a minimum value for replay memory ceiling #308

Conversation

xperimental
Copy link

@xperimental xperimental commented Jun 3, 2024

What this PR does / why we need it:

This is a backport of grafana#13066 to release-5.6.

Which issue(s) this PR fixes:

Fixes LOG-5617

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jun 3, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jun 3, 2024

@xperimental: This pull request references LOG-5617 which is a valid jira issue.

In response to this:

What this PR does / why we need it:

This is a backport of grafana#13066 to release-5.6.

Which issue(s) this PR fixes:

Fixes LOG-5617

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

1 similar comment
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jun 3, 2024

@xperimental: This pull request references LOG-5617 which is a valid jira issue.

In response to this:

What this PR does / why we need it:

This is a backport of grafana#13066 to release-5.6.

Which issue(s) this PR fixes:

Fixes LOG-5617

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested review from btaani and jcantrill June 3, 2024 18:48
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 3, 2024
Copy link

openshift-ci bot commented Jun 3, 2024

@xperimental: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@periklis
Copy link

periklis commented Jun 4, 2024

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 4, 2024
Copy link

openshift-ci bot commented Jun 4, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: periklis, xperimental

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [periklis,xperimental]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 7a3abe1 into openshift:release-5.6 Jun 4, 2024
7 checks passed
@xperimental xperimental deleted the fix-replay-ceiling-5.6 branch June 4, 2024 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants