[WIP] OCPBUGS-45924: for PodSucceeded static pod should always be pending

[tkashem]

the following conditions:

• a) pod.Status.Phase == PodSucceeded
• b) pod.Status.Condition[type==corev1.PodReady]: status == corev1.ConditionTrue

if kubelet does not update the Pod status (a and b) atomically then there is a gap between when 1) pod.Status.Phase is set to PodSucceeded and 2) the PodReady condition is updated to False

if a and b are true then we may signal that "static pod is ready" on the designated node, which may cause the installer controller to create a new installer pod on a different node
if a is true, this alone can be used to say that "static pod is pending" on the designated node.

[openshift-ci-robot]

@tkashem: This pull request references Jira Issue OCPBUGS-45924, which is invalid:

• expected the bug to target the "4.19.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

I don't know much about how the Ready condition of a static pod is updated, but if for some reason, kubelet can't update the status of the Ready condition to "False" when the Pod gracefully exits then the installer controller may deem a static pod that has just completed as "static pod is ready"

Hypothetically, this may cause the installer controller to create an installer Pod on a different node that could lead to quorum loss?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tkashem

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• pkg/operator/staticpod/OWNERS [tkashem]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[tkashem]

proof PR: openshift/cluster-etcd-operator#1385

[tkashem]

/cc @dgrisonnet @benluddy (I am probably missing something obvious)

[openshift-ci]

@tkashem: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.