WIP: NOMERGE: DNM: consume u/s PR 126750 #2088
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ncorecache is enabled.
…o take CPUs by uncourecache grouping.
openshift-ci-robot
added
the
backports/unvalidated-commits
openshift-ci
bot
added
the
do-not-merge/work-in-progress
|
@ffromani: the contents of this pull request could not be automatically validated. The following commits could not be validated and must be approved by a top-level approver:
Comment |
ffromani
changed the title
|
/hold |
openshift-ci
bot
added
the
do-not-merge/hold
adapt to the older codebase Signed-off-by: Francesco Romani <fromani@redhat.com>
ffromani
force-pushed
the
ocp-consume-pr-126750-4.16
branch
from
9270305
to
9abda8e
Compare
|
@ffromani: the contents of this pull request could not be automatically validated. The following commits could not be validated and must be approved by a top-level approver:
Comment |
|
/test k8s-e2e-aws-ovn-serial |
|
@ffromani: the contents of this pull request could not be automatically validated. The following commits could not be validated and must be approved by a top-level approver:
Comment |
In order to improve the observability of the resource management in kubelet, cpu allocation and NUMA alignment, we add more metrics to report if resource alignment is in effect. The more precise reporting would probably be using pod status, but this would require more invasive and riskier changes, and possibly extra interactions to the APIServer. We start adding metrics to report if containers got their compute resources aligned. If metrics are growing, the assingment is working as expected; If metrics stay consistent, perhaps at zero, no resource alignment is done. Signed-off-by: Francesco Romani <fromani@redhat.com>
wire in the l3 group alignment metrics Signed-off-by: Francesco Romani <fromani@redhat.com>
make sure to log the patched version Signed-off-by: Francesco Romani <fromani@redhat.com>
ffromani
force-pushed
the
ocp-consume-pr-126750-4.16
branch
from
139d258
to
bb9b972
Compare
|
@ffromani: the contents of this pull request could not be automatically validated. The following commits could not be validated and must be approved by a top-level approver:
Comment |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: ffromani The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
add more verbose logs by default to make the LLC algorithm debuggable. Signed-off-by: Francesco Romani <fromani@redhat.com>
ffromani
force-pushed
the
ocp-consume-pr-126750-4.16
branch
from
bb9b972
to
7c58cf7
Compare
|
@ffromani: the contents of this pull request could not be automatically validated. The following commits could not be validated and must be approved by a top-level approver:
Comment |
|
/test |
|
@ffromani: The
The following commands are available to trigger optional jobs:
Use
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/test k8s-e2e-aws |
fix logging to reflect what takeFullUnCoreCache actually did; with the buggy code it was still inferrable from the logs, but it has to be explicit. Signed-off-by: Francesco Romani <fromani@redhat.com>
|
@ffromani: the contents of this pull request could not be automatically validated. The following commits could not be validated and must be approved by a top-level approver:
Comment |
Signed-off-by: Francesco Romani <fromani@redhat.com>
|
@ffromani: the contents of this pull request could not be automatically validated. The following commits could not be validated and must be approved by a top-level approver:
Comment |
|
/test k8s-e2e-aws |
A log in `topology` subpkg was too spammy. Bump its verbosiness. Signed-off-by: Francesco Romani <fromani@redhat.com>
|
@ffromani: the contents of this pull request could not be automatically validated. The following commits could not be validated and must be approved by a top-level approver:
Comment |
|
@ffromani: the contents of this pull request could not be automatically validated. The following commits could not be validated and must be approved by a top-level approver:
Comment |
no uncore cache can be treated as all CPUs belonging to the same group, so alignment is implicit and always guaranteed. Signed-off-by: Francesco Romani <fromani@redhat.com>
ffromani
force-pushed
the
ocp-consume-pr-126750-4.16
branch
from
0b29578
to
6a21e34
Compare
|
@ffromani: the contents of this pull request could not be automatically validated. The following commits could not be validated and must be approved by a top-level approver:
Comment |
further improve throubleshooting to check if the LLC alignment code is engaging. Signed-off-by: Francesco Romani <fromani@redhat.com>
|
@ffromani: the contents of this pull request could not be automatically validated. The following commits could not be validated and must be approved by a top-level approver:
Comment |
|
@ffromani: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP DNM