Bug 1993977: Bump to 0.11.0 #50

paulfantom · 2021-08-10T13:51:28Z

Signed-off-by: paulfantom pawel@krupa.net.pl

Signed-off-by: paulfantom <pawel@krupa.net.pl>

Fix waiting for kind cluster in e2e tests

Setting a nil-value typed object in the `DelegatingAuthenticatorConfig` will cause the generic logic to still evaluate is as non-nil since Golang does not consider `(*type)(nil)` as `nil` in `== nil` comparison unless `type == nil`, too. This leads to a setup of an x509 authenticator that attempts to call `VerifyOptions` on a nil object.

Signed-off-by: paulfantom <pawel@krupa.net.pl>

.github/workflows: enable golangci-lint

Signed-off-by: Sergiusz Urbaniak <sergiusz.urbaniak@gmail.com>

VERSION: fix v0.10.0

allow path patterns in --allow-paths and --ignore-paths

Signed-off-by: Sergiusz Urbaniak <sergiusz.urbaniak@gmail.com>

*: cut v0.11.0 release

* release-0.11: CHANGELOG.md: add 0.10.0 release notes *: cut v0.11.0 release allow path pattern in --allow-paths and --ignore-paths examples: regenerate VERSION: fix v0.10.0 *: lint code .golangci: configure .github/workflows: enable golangci-lint Prevent panics on client-cert authenticated requests Fix waiting for kind cluster in e2e tests

s-urbaniak · 2021-08-11T07:23:30Z

/lgtm

simonpasquier · 2021-08-16T12:38:23Z

/lgtm

I think that brancz#132 would deserve a bugzilla: a team configuring a service monitor with TLS client authentication but not passing the client CA file to kube-rbac-proxy would trigger a panic of kube-rbac-proxy. Though such a change wouldn't pass CI tests, it's not a nice user experience and hard to troubleshoot.

openshift-ci · 2021-08-16T12:39:49Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: paulfantom, s-urbaniak, simonpasquier

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [s-urbaniak]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci · 2021-08-16T13:21:56Z

@paulfantom: This pull request references Bugzilla bug 1993977, which is invalid:

expected the bug to target the "4.9.0" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 1993977: Bump to 0.11.0

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

paulfantom · 2021-08-16T13:21:58Z

/bugzilla refresh

openshift-ci · 2021-08-16T13:22:01Z

@paulfantom: This pull request references Bugzilla bug 1993977, which is invalid:

expected the bug to target the "4.9.0" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

paulfantom · 2021-08-16T13:22:14Z

/bugzilla refresh

paulfantom · 2021-08-16T13:22:47Z

/bugzilla refresh

openshift-ci · 2021-08-16T13:22:54Z

@paulfantom: This pull request references Bugzilla bug 1993977, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.9.0) matches configured target release for branch (4.9.0)
bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @juzhao

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci · 2021-08-16T13:23:19Z

@paulfantom: This pull request references Bugzilla bug 1993977, which is valid.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.9.0) matches configured target release for branch (4.9.0)
bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @juzhao

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci · 2021-08-16T13:26:33Z

@paulfantom: All pull requests linked via external trackers have merged:

openshift/kube-rbac-proxy#50

Bugzilla bug 1993977 has been moved to the MODIFIED state.

In response to this:

Bug 1993977: Bump to 0.11.0

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2023-11-25T01:09:55Z

[ART PR BUILD NOTIFIER]

This PR has been included in build kube-rbac-proxy-container-v4.9.0-202311250023.p0.g58e0929.assembly.stream for distgit kube-rbac-proxy.
All builds following this will include this PR.

paulfantom and others added 17 commits July 21, 2021 10:32

Fix waiting for kind cluster in e2e tests

f58aefe

Signed-off-by: paulfantom <pawel@krupa.net.pl>

Merge pull request brancz#133 from brancz/ci-fix

77f8adf

Fix waiting for kind cluster in e2e tests

Merge pull request brancz#132 from stlaz/clientca_fix

b33e775

.github/workflows: enable golangci-lint

a2a090a

.golangci: configure

656b2b6

*: lint code

411e2cb

Signed-off-by: paulfantom <pawel@krupa.net.pl>

Merge pull request brancz#136 from paulfantom/add-linter

07c9b64

.github/workflows: enable golangci-lint

VERSION: fix v0.10.0

d9a5793

Signed-off-by: Sergiusz Urbaniak <sergiusz.urbaniak@gmail.com>

examples: regenerate

2be3123

Merge pull request brancz#137 from s-urbaniak/fix-version

12dbeae

VERSION: fix v0.10.0

allow path pattern in --allow-paths and --ignore-paths

dd334c6

Merge pull request brancz#135 from raptorsun/feature/trailing_wildcards

8f1fd65

allow path patterns in --allow-paths and --ignore-paths

*: cut v0.11.0 release

19a26d0

Signed-off-by: Sergiusz Urbaniak <sergiusz.urbaniak@gmail.com>

CHANGELOG.md: add 0.10.0 release notes

f93e5a2

Merge pull request brancz#138 from s-urbaniak/v0.11.0

fa09bd6

*: cut v0.11.0 release

paulfantom changed the title ~~Fix waiting for kind cluster in e2e tests~~ Bump to 0.11.0 Aug 10, 2021

openshift-ci bot requested review from s-urbaniak and stlaz August 10, 2021 13:52

openshift-ci bot assigned s-urbaniak Aug 11, 2021

openshift-ci bot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Aug 11, 2021

raptorsun mentioned this pull request Aug 11, 2021

[MON-1695] expose /api/v1/labels end point for Thanos query. openshift/cluster-monitoring-operator#1299

Merged

2 tasks

openshift-ci bot assigned simonpasquier Aug 16, 2021

paulfantom changed the title ~~Bump to 0.11.0~~ Bug 1993977: Bump to 0.11.0 Aug 16, 2021

openshift-ci bot added the bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. label Aug 16, 2021

openshift-ci bot added the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Aug 16, 2021

openshift-ci bot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Aug 16, 2021

openshift-ci bot removed the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Aug 16, 2021

openshift-ci bot requested a review from juzhao August 16, 2021 13:22

openshift-ci bot merged commit 58e0929 into openshift:master Aug 16, 2021

paulfantom deleted the bump-to-0.11.0 branch August 16, 2021 13:29

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Bug 1993977: Bump to 0.11.0 #50

Bug 1993977: Bump to 0.11.0 #50

paulfantom commented Aug 10, 2021

s-urbaniak commented Aug 11, 2021

simonpasquier commented Aug 16, 2021

openshift-ci bot commented Aug 16, 2021

openshift-ci bot commented Aug 16, 2021

paulfantom commented Aug 16, 2021

openshift-ci bot commented Aug 16, 2021

paulfantom commented Aug 16, 2021

paulfantom commented Aug 16, 2021

openshift-ci bot commented Aug 16, 2021

openshift-ci bot commented Aug 16, 2021

openshift-ci bot commented Aug 16, 2021

openshift-bot commented Nov 25, 2023

Bug 1993977: Bump to 0.11.0 #50

Bug 1993977: Bump to 0.11.0 #50

Conversation

paulfantom commented Aug 10, 2021

s-urbaniak commented Aug 11, 2021

simonpasquier commented Aug 16, 2021

openshift-ci bot commented Aug 16, 2021

openshift-ci bot commented Aug 16, 2021

paulfantom commented Aug 16, 2021

openshift-ci bot commented Aug 16, 2021

paulfantom commented Aug 16, 2021

paulfantom commented Aug 16, 2021

openshift-ci bot commented Aug 16, 2021

openshift-ci bot commented Aug 16, 2021

openshift-ci bot commented Aug 16, 2021

openshift-bot commented Nov 25, 2023