-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OCPBUGS-30516: bump golang-protobuf for CVE fix #8379
OCPBUGS-30516: bump golang-protobuf for CVE fix #8379
Conversation
@r4f4: This pull request references Jira Issue OCPBUGS-30516, which is valid. The bug has been moved to the POST state. 3 validation(s) were run on this bug
Requesting review from QA contact: The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
/retest-required |
/test images |
2 similar comments
/test images |
/test images |
/retest |
/test images |
/retest-required |
Bump golang.org/protobuf to v1.33.0 for CVE-2024-24786 fix. Notice that, in some cases, github.com/golang/protobuf had to be bumped to v1.5.4 because of golang/protobuf#1596.
Update: rebased after the removal of some terraform providers. |
/override ci/prow/okd-images |
/cherry-pick release-4.16 |
@r4f4: once the present PR merges, I will cherry-pick it on top of release-4.16 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
@r4f4: Overrode contexts on behalf of r4f4: ci/prow/okd-images In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/retest-required |
/lgtm |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sadasu The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/override ci/prow/okd-images |
@r4f4: Overrode contexts on behalf of r4f4: ci/prow/okd-images In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/hold cancel |
/test e2e-azure-ovn |
/test ? |
@r4f4: The following commands are available to trigger required jobs:
The following commands are available to trigger optional jobs:
Use
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/test e2e-nutanix-ovn altinfra-e2e-azure-capi-ovn altinfra-e2e-gcp-capi-ovn |
/hold |
/test e2e-azure-ovn |
/hold cancel I was seeing ~40 e2e failures in the azure-ovn job but I noticed they also happened in other azure jobs from other PRs (azurestack and azure-ovn-upi) and now I see the failures dropped to ~7. I don't think they are related to this PR. |
/override ci/prow/e2e-azure-ovn |
@r4f4: Overrode contexts on behalf of r4f4: ci/prow/e2e-azure-ovn In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/override ci/prow/okd-images |
@r4f4: Overrode contexts on behalf of r4f4: ci/prow/okd-images In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
@r4f4: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
/override ci/prow/e2e-aws-ovn ci/prow/e2e-gcp-ovn |
@r4f4: Overrode contexts on behalf of r4f4: ci/prow/e2e-aws-ovn, ci/prow/e2e-gcp-ovn In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
3204a5a
into
openshift:master
@r4f4: Jira Issue OCPBUGS-30516: All pull requests linked via external trackers have merged: Jira Issue OCPBUGS-30516 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
/cherry-pick release-4.16 |
[ART PR BUILD NOTIFIER] This PR has been included in build ose-installer-altinfra-container-v4.17.0-202405262242.p0.g3204a5a.assembly.stream.el9 for distgit ose-installer-altinfra. |
/cherry-pick release-4.16 |
1 similar comment
/cherry-pick release-4.16 |
Bump golang.org/protobuf to v1.33.0 for GHSA-8r3f-844c-mc37 fix.
Notice that, in some cases, github.com/golang/protobuf had to be bumped to v1.5.4 because of golang/protobuf#1596.