Add SRV records for bootstrapping etcd using DNS. #526
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
do-not-merge/work-in-progress
abhinavdahiya
force-pushed
the
etcd_dns
branch
from
5f7ee32
to
51ecaad
Compare
abhinavdahiya
changed the title
openshift-ci-robot
removed
the
do-not-merge/work-in-progress
|
/retest |
abhinavdahiya
force-pushed
the
etcd_dns
branch
from
51ecaad
to
f4f17da
Compare
|
/lgtm Waiting on dmacvicar/terraform-provider-libvirt#460. |
openshift-ci-robot
added
do-not-merge/hold
Add SRV records for bootstrapping etcd using DNS. xref: https://github.com/etcd-io/etcd/blob/master/Documentation/op-guide/clustering.md#dns-discovery
abhinavdahiya
force-pushed
the
etcd_dns
branch
from
f4f17da
to
8343ccf
Compare
|
/lgtm |
|
Let's use your fork of terraform-provider-libvirt for now. Can you add a note to the docs? /lgtm cancel |
dmacvicar/terraform-provider-libvirt#460 is pending approval, so in the mean time changing the docs to point to forked repo for getting DNS SRV changes.
|
/lgtm |
openshift-ci-robot
added
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: abhinavdahiya, crawford The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest |
1 similar comment
|
/retest |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
abhinavdahiya
added a commit
to abhinavdahiya/installer
that referenced
this pull request
Nov 2, 2018
openshift#526 added the etcd srv records on basedomain, this can be problematic and might collide. This was working on AWS right now due to the fact that we were using internal route53 zone. This keeps the old srvs inplace for now, so that when MCO switches to these new records we can comeback and remove `*_old_srvs`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add SRV records for bootstrapping etcd using DNS.
xref: https://github.com/etcd-io/etcd/blob/master/Documentation/op-guide/clustering.md#dns-discovery
Requires: dmacvicar/terraform-provider-libvirt#460
This allows MCO to use this to bootstrap etcd openshift/machine-config-operator#143