Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Go Modules Migration #2745

Merged
merged 12 commits into from
Feb 19, 2020
Merged

Go Modules Migration #2745

merged 12 commits into from
Feb 19, 2020
+3,778,672 −4,096,268

Commits on Feb 13, 2020

  1. Prepare migration to Go Modules and 1.13

    @LorbusChris
    LorbusChris committed Feb 13, 2020
    Configuration menu
    Copy the full SHA
    8218eed View commit details
    Browse the repository at this point in the history

  2. Migrate all terraform providers to terraform-plugin-sdk

    @LorbusChris
    LorbusChris committed Feb 13, 2020
    Configuration menu
    Copy the full SHA
    76fc132 View commit details
    Browse the repository at this point in the history

  3. data/data: Fixup tf files for updated providers 

    * Fixups for updated Terraform syntax

* Ignition: With the new provider version the Ignition spec
elements are required to be referenced by their `.rendered`
property instead of `.id`

* Azure: Fixes: 'Error: Invalid index. azurerm_public_ip.bootstrap_public_ip_v6
is empty tuple. The given key does not identify an element in this collection
value.'

* Azure: Fixes 'Warning: "attempts": [DEPRECATED] Retries are now
handled by the Azure SDK as such this field is no longer
necessary and will be removed in v2.0 of the Azure Provider'
    @LorbusChris
    LorbusChris committed Feb 13, 2020
    Configuration menu
    Copy the full SHA
    290df6a View commit details
    Browse the repository at this point in the history

  4. data/aws/vpc: Tag VPC endpoints 

    The Terraform-provider bump brought in
hashicorp/terraform-provider-aws@864285b1bb (Tagging for VPC
Endpoints and VPC Endpoint Services, 2019-05-15,
hashicorp/terraform-provider-aws#8674, v2.16.0).

Also wire this into the deleteARN tree.  VPC endpoint ARNs look like:

  arn:aws:ec2:{region}:{account}:vpc-endpoint/vpce-123...
    @wking @LorbusChris
    wking authored and LorbusChris committed Feb 13, 2020
    Configuration menu
    Copy the full SHA
    7ca7f0e View commit details
    Browse the repository at this point in the history

  5. Fixup GCP Uninstaller to account for changed base path 

    The definition of the Compute Base Path has changed in the Google API  and can't be used for determining Zone and Instance URLs anymore.

This commit hardcodes the correct base path.
A better way to do this should be found in the future to account for changes in the base path.

Old Compute Base Path: https://www.googleapis.com/compute/v1/projects/
New Compute Base Path:  https://compute.googleapis.com/compute/v1/projects/
Unchanged Zone URL: https://www.googleapis.com/compute/v1/projects/project-id/zones/us-central1-a
    @LorbusChris
    LorbusChris committed Feb 13, 2020
    Configuration menu
    Copy the full SHA
    11c9773 View commit details
    Browse the repository at this point in the history

  6. Remove pkg/terraform/exec/vendor/

    @LorbusChris
    LorbusChris committed Feb 13, 2020
    Configuration menu
    Copy the full SHA
    d239e2f View commit details
    Browse the repository at this point in the history

  7. Remove pkg/terraform/exec/plugins/vendor/

    @LorbusChris
    LorbusChris committed Feb 13, 2020
    Configuration menu
    Copy the full SHA
    ac73da7 View commit details
    Browse the repository at this point in the history

  8. Remove Gopkg files

    @LorbusChris
    LorbusChris committed Feb 13, 2020
    Configuration menu
    Copy the full SHA
    3843fbe View commit details
    Browse the repository at this point in the history

  9. Fixup pkg/asset/machines/{master,worker}_test.go 

    Add kernelType field to expected MachineConfig results
in order to account for updated MCO, where this was added recently.
    @LorbusChris
    LorbusChris committed Feb 13, 2020
    Configuration menu
    Copy the full SHA
    107a577 View commit details
    Browse the repository at this point in the history

  10. docs: Update dependencies.md

    @LorbusChris
    LorbusChris committed Feb 13, 2020
    Configuration menu
    Copy the full SHA
    947795d View commit details
    Browse the repository at this point in the history

  11. Add go.mod

    @LorbusChris
    LorbusChris committed Feb 13, 2020
    Configuration menu
    Copy the full SHA
    7f2e4ab View commit details
    Browse the repository at this point in the history

  12. Update vendor

    @LorbusChris
    LorbusChris committed Feb 13, 2020
    Configuration menu
    Copy the full SHA
    d02d3f0 View commit details
    Browse the repository at this point in the history