-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OCPBUGS-959: manifests/02-namespace: Explicitly clear run-level label #672
OCPBUGS-959: manifests/02-namespace: Explicitly clear run-level label #672
Conversation
@wking: This pull request references Jira Issue OCPBUGS-959, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
The label was dropped back in: $ git --no-pager log -1 --oneline 75f34c7 75f34c7 manifests: Remove run-level, insights operator does not need it That landed between 4.2 and 4.3: $ git --no-pager grep openshift.io/run-level origin/release-4.2 -- manifests origin/release-4.2:manifests/02-namespace.yaml: openshift.io/run-level: "1" $ git --no-pager grep openshift.io/run-level origin/release-4.3 -- manifests ...no hits... So clusters which were born in 4.1 or 4.2 may have the old label still in place. This commit clears it like openshift/cluster-version-operator@539e944920 (Fix run-level label to empty string, 2021-07-07, openshift/cluster-version-operator#623), so the cluster-version operator will clear the stale label.
41e7429
to
a1eed66
Compare
@wking: This pull request references Jira Issue OCPBUGS-959, which is valid. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Unsetting the old label. Thanks. |
Failing to install on slow Azure instances is unrelated. /test ci/prow/e2e-agnostic-upgrade |
@wking: The specified target(s) for
Use
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/test e2e-agnostic-upgrade |
/test insights-operator-e2e-tests |
/approved |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: tremes, wking The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@wking: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
@wking: All pull requests linked via external trackers have merged: Jira Issue OCPBUGS-959 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Extend b76516a (blocked-edges/4.11.*: Declare StaleInsightsRunLevelLabel risk, 2022-09-06, openshift#2457) to 4.11.4, because the fix just landed in the development branch [1] and has yet to be backported to 4.11.z. Generated with: $ V=4.11.4; sed "s/4[.]11[.]0/${V}/g" blocked-edges/4.11.0-stale-insights-run-level-label.yaml > "blocked-edges/${V}-stale-insights-run-level-label.yaml" [1]: openshift/insights-operator#672
/cherry-pick release-4.11 |
@sdodson: new pull request created: #676 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
The label was dropped back in:
That landed between 4.2 and 4.3:
So clusters which were born in 4.1 or 4.2 may have the old label still in place. This commit clears it like openshift/cluster-version-operator@539e944920 (openshift/cluster-version-operator#623), so the cluster-version operator will clear the stale label.
Categories