Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCPBUGS-959: manifests/02-namespace: Explicitly clear run-level label #672

Merged

Conversation

wking
Copy link
Member

@wking wking commented Sep 6, 2022

The label was dropped back in:

$ git --no-pager log -1 --oneline 75f34c7a944e20904d48949a3bd9b1f9496252c0
75f34c7a manifests: Remove run-level, insights operator does not need it

That landed between 4.2 and 4.3:

$ git --no-pager grep openshift.io/run-level origin/release-4.2 -- manifests
origin/release-4.2:manifests/02-namespace.yaml:    openshift.io/run-level: "1"
$ git --no-pager grep openshift.io/run-level origin/release-4.3 -- manifests
...no hits...

So clusters which were born in 4.1 or 4.2 may have the old label still in place. This commit clears it like openshift/cluster-version-operator@539e944920 (openshift/cluster-version-operator#623), so the cluster-version operator will clear the stale label.

Categories

  • Bugfix
  • Enhancement
  • Backporting
  • Others (CI, Infrastructure, Documentation)

@openshift-ci-robot openshift-ci-robot added jira/severity-moderate Referenced Jira bug's severity is moderate for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. labels Sep 6, 2022
@openshift-ci-robot
Copy link
Contributor

@wking: This pull request references Jira Issue OCPBUGS-959, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.12.0) matches configured target version for branch (4.12.0)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

In response to this:

The annotation was dropped back in:

$ git --no-pager log -1 --oneline 75f34c7a944e20904d48949a3bd9b1f9496252c0
75f34c7a manifests: Remove run-level, insights operator does not need it

That landed between 4.2 and 4.3:

$ git --no-pager grep openshift.io/run-level origin/release-4.2 -- manifests
origin/release-4.2:manifests/02-namespace.yaml:    openshift.io/run-level: "1"
$ git --no-pager grep openshift.io/run-level origin/release-4.3 -- manifests
...no hits...

So clusters which were born in 4.1 or 4.2 may have the old annotation still in place. This commit clears it like openshift/cluster-version-operator@539e944920 (openshift/cluster-version-operator#623), so the cluster-version operator will clear the stale annotation.

Categories

  • Bugfix
  • Enhancement
  • Backporting
  • Others (CI, Infrastructure, Documentation)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Sep 6, 2022
@openshift-ci openshift-ci bot requested review from iNecas and tremes September 6, 2022 20:41
The label was dropped back in:

  $ git --no-pager log -1 --oneline 75f34c7
  75f34c7 manifests: Remove run-level, insights operator does not need it

That landed between 4.2 and 4.3:

  $ git --no-pager grep openshift.io/run-level origin/release-4.2 -- manifests
  origin/release-4.2:manifests/02-namespace.yaml:    openshift.io/run-level: "1"
  $ git --no-pager grep openshift.io/run-level origin/release-4.3 -- manifests
  ...no hits...

So clusters which were born in 4.1 or 4.2 may have the old label
still in place.  This commit clears it like
openshift/cluster-version-operator@539e944920 (Fix run-level label to
empty string, 2021-07-07, openshift/cluster-version-operator#623), so
the cluster-version operator will clear the stale label.
@wking wking changed the title OCPBUGS-959: manifests/02-namespace: Explicitly clear run-level annotation OCPBUGS-959: manifests/02-namespace: Explicitly clear run-level label Sep 6, 2022
@openshift-ci-robot
Copy link
Contributor

@wking: This pull request references Jira Issue OCPBUGS-959, which is valid. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.12.0) matches configured target version for branch (4.12.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

In response to this:

The label was dropped back in:

$ git --no-pager log -1 --oneline 75f34c7a944e20904d48949a3bd9b1f9496252c0
75f34c7a manifests: Remove run-level, insights operator does not need it

That landed between 4.2 and 4.3:

$ git --no-pager grep openshift.io/run-level origin/release-4.2 -- manifests
origin/release-4.2:manifests/02-namespace.yaml:    openshift.io/run-level: "1"
$ git --no-pager grep openshift.io/run-level origin/release-4.3 -- manifests
...no hits...

So clusters which were born in 4.1 or 4.2 may have the old label still in place. This commit clears it like openshift/cluster-version-operator@539e944920 (openshift/cluster-version-operator#623), so the cluster-version operator will clear the stale label.

Categories

  • Bugfix
  • Enhancement
  • Backporting
  • Others (CI, Infrastructure, Documentation)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tremes
Copy link
Contributor

tremes commented Sep 7, 2022

Unsetting the old label. Thanks.
/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 7, 2022
@wking
Copy link
Member Author

wking commented Sep 7, 2022

Failing to install on slow Azure instances is unrelated.

/test ci/prow/e2e-agnostic-upgrade

@openshift-ci
Copy link

openshift-ci bot commented Sep 7, 2022

@wking: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

  • /test e2e
  • /test e2e-agnostic-upgrade
  • /test e2e-metal-ipi-ovn-ipv6
  • /test images
  • /test insights-operator-e2e-tests
  • /test lint
  • /test unit

Use /test all to run the following jobs that were automatically triggered:

  • pull-ci-openshift-insights-operator-master-e2e
  • pull-ci-openshift-insights-operator-master-e2e-agnostic-upgrade
  • pull-ci-openshift-insights-operator-master-images
  • pull-ci-openshift-insights-operator-master-insights-operator-e2e-tests
  • pull-ci-openshift-insights-operator-master-lint
  • pull-ci-openshift-insights-operator-master-unit

In response to this:

Failing to install on slow Azure instances is unrelated.

/test ci/prow/e2e-agnostic-upgrade

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@wking
Copy link
Member Author

wking commented Sep 7, 2022

/test e2e-agnostic-upgrade

@wking
Copy link
Member Author

wking commented Sep 7, 2022

insights-operator-e2e-tests is flaky, and the failure seems unrelated to my label change.

/test insights-operator-e2e-tests

@tremes
Copy link
Contributor

tremes commented Sep 7, 2022

/approved

@tremes
Copy link
Contributor

tremes commented Sep 7, 2022

/approve

@openshift-ci
Copy link

openshift-ci bot commented Sep 7, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tremes, wking

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 7, 2022
@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 9e528ed and 2 for PR HEAD a1eed66 in total

@openshift-ci
Copy link

openshift-ci bot commented Sep 7, 2022

@wking: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit 96562f2 into openshift:master Sep 7, 2022
@openshift-ci-robot
Copy link
Contributor

@wking: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-959 has been moved to the MODIFIED state.

In response to this:

The label was dropped back in:

$ git --no-pager log -1 --oneline 75f34c7a944e20904d48949a3bd9b1f9496252c0
75f34c7a manifests: Remove run-level, insights operator does not need it

That landed between 4.2 and 4.3:

$ git --no-pager grep openshift.io/run-level origin/release-4.2 -- manifests
origin/release-4.2:manifests/02-namespace.yaml:    openshift.io/run-level: "1"
$ git --no-pager grep openshift.io/run-level origin/release-4.3 -- manifests
...no hits...

So clusters which were born in 4.1 or 4.2 may have the old label still in place. This commit clears it like openshift/cluster-version-operator@539e944920 (openshift/cluster-version-operator#623), so the cluster-version operator will clear the stale label.

Categories

  • Bugfix
  • Enhancement
  • Backporting
  • Others (CI, Infrastructure, Documentation)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@wking wking deleted the clear-run-level-annotation branch September 7, 2022 16:54
wking added a commit to wking/cincinnati-graph-data that referenced this pull request Sep 7, 2022
Extend b76516a (blocked-edges/4.11.*: Declare
StaleInsightsRunLevelLabel risk, 2022-09-06, openshift#2457) to 4.11.4, because
the fix just landed in the development branch [1] and has yet to be
backported to 4.11.z.

Generated with:

  $ V=4.11.4; sed "s/4[.]11[.]0/${V}/g" blocked-edges/4.11.0-stale-insights-run-level-label.yaml > "blocked-edges/${V}-stale-insights-run-level-label.yaml"

[1]: openshift/insights-operator#672
@sdodson
Copy link
Member

sdodson commented Sep 12, 2022

/cherry-pick release-4.11

@openshift-cherrypick-robot

@sdodson: new pull request created: #676

In response to this:

/cherry-pick release-4.11

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. jira/severity-moderate Referenced Jira bug's severity is moderate for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants