-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Touch runtime detection fields if runtime selection succeedes #739
Touch runtime detection fields if runtime selection succeedes #739
Conversation
@rottencandy: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #739 +/- ##
==========================================
+ Coverage 83.56% 83.71% +0.15%
==========================================
Files 496 499 +3
Lines 12184 12310 +126
Branches 3479 3532 +53
==========================================
+ Hits 10181 10305 +124
- Misses 1887 1889 +2
Partials 116 116
... and 14 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
/retest |
/cc @karthikjeeyar |
/lgtm |
/cc @rohitkrai03 |
/retest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rohitkrai03, rottencandy The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Fixes
https://issues.redhat.com/browse/RHTAPBUGS-479
Description
Formik bug workaround suddenly stopped working, updated to use jaredpalmer/formik#2083 (comment)
Type of change
Screen shots / Gifs for design review
recording-1690560371.mp4
How to test or reproduce?
(see ticket)
Browser conformance: