Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move NodeSwap to TechPreviewNoUpgrade feature set #975

Merged
merged 1 commit into from
Dec 4, 2021

Conversation

ehashman
Copy link
Contributor

@ehashman ehashman commented Dec 3, 2021

Per @deads2k requested API changes.

/cc @rphillips @mrunalp @deads2k

@deads2k
Copy link
Contributor

deads2k commented Dec 3, 2021

This is in keeping with how we manage our featuregates. Rather than have a customer individually enable them, we curate a set of techpreview featuregates. This prevents a proliferation of featuresets.

Nearly every component raises the, "what if a customer just wants my featuregate", but from a practical perspective supporting a configuration like that expands our test matrix and in every case so far it has not actually been necessary to provide an individual featuregate enablement. In addition, you benefit from the the techpreview CI by doing this instead of having to create variants of every job for your node-swap setting.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Dec 3, 2021
Copy link
Member

@mrunalp mrunalp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 4, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mrunalp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 4, 2021
@openshift-merge-robot openshift-merge-robot merged commit 389f8e4 into openshift:master Dec 4, 2021
@ehashman ehashman deleted the swap-feature-gate branch December 6, 2021 22:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants