-
Notifications
You must be signed in to change notification settings - Fork 463
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
template: remove status field and replace with jira field #953
template: remove status field and replace with jira field #953
Conversation
/assign @dhellmann |
guidelines/enhancement_template.md
Outdated
@@ -74,6 +75,7 @@ around the enhancement process. | |||
## Release Signoff Checklist |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As part of this change, we can also remove this entire section. We should make sure the items listed here are represented in the rest of the template, but we don't want people to feel obligated to come back and update the checklist and we won't merge enhancements until all of the necessary parts are filled in.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
that makes sense to me, the checklist always ends up falling behind.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the User Docs is the one missing, I see 2 places we can add it template:
- between test plan and graduation criteria as its own section to highlight or within graduation criteria
- as a question in Graduation Criteria
Something like: Does this enhancement require an update to user-facing documentation in openshift-docs?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's start with a question in the graduation criteria for now. We're going to review that section in a later update and we can decide then if we want to leave the question there or add a new section to talk about doc updates.
0ea8764
to
4c50ec2
Compare
Also update instructions to included note about stakeholder agreement and implementation timeline
4c50ec2
to
df61b32
Compare
Looks good! /approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dhellmann The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm |
No description provided.