Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

template: remove status field and replace with jira field #953

Merged

Conversation

kikisdeliveryservice
Copy link
Contributor

No description provided.

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 8, 2021
@kikisdeliveryservice
Copy link
Contributor Author

/assign @dhellmann

guidelines/enhancement_template.md Outdated Show resolved Hide resolved
@@ -74,6 +75,7 @@ around the enhancement process.
## Release Signoff Checklist
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As part of this change, we can also remove this entire section. We should make sure the items listed here are represented in the rest of the template, but we don't want people to feel obligated to come back and update the checklist and we won't merge enhancements until all of the necessary parts are filled in.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that makes sense to me, the checklist always ends up falling behind.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the User Docs is the one missing, I see 2 places we can add it template:

  1. between test plan and graduation criteria as its own section to highlight or within graduation criteria
  2. as a question in Graduation Criteria

Something like: Does this enhancement require an update to user-facing documentation in openshift-docs?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's start with a question in the graduation criteria for now. We're going to review that section in a later update and we can decide then if we want to leave the question there or add a new section to talk about doc updates.

@kikisdeliveryservice kikisdeliveryservice force-pushed the deprecate-status branch 6 times, most recently from 0ea8764 to 4c50ec2 Compare November 11, 2021 00:10
Also update instructions to included note about stakeholder
agreement and implementation timeline
@kikisdeliveryservice kikisdeliveryservice changed the title [WIP] template: remove status field and replace with jira field template: remove status field and replace with jira field Nov 11, 2021
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 11, 2021
@dhellmann
Copy link
Contributor

Looks good!

/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 11, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dhellmann

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 11, 2021
@bparees
Copy link
Contributor

bparees commented Nov 11, 2021

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 11, 2021
@openshift-merge-robot openshift-merge-robot merged commit 1eb0d4b into openshift:master Nov 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants