Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Insights pulling SCA certs - graduation criteria update #947

Merged
merged 1 commit into from
Nov 4, 2021

Conversation

tremes
Copy link
Contributor

@tremes tremes commented Nov 3, 2021

No description provided.

@@ -138,7 +138,7 @@ This feature is planned as a technical preview in OCP 4.9 and is planned to go G
- this new functionality is documented in the Insights Operator documentation as tech preview

#### Tech Preview -> GA
- `Share` resource object is automatically created by the Insights Operator
- ~~`Share` resource object is automatically created by the Insights Operator~~ - `Share` object will still be a tech preview in 4.10. Build team can enhance/create it later
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i don't think it's important to reference version numbers in EPs, the roadmap is intended to define the technical milestones that the feature will go through/requirements at each milestone, not the specific release when we expect to achieve them.

Since this is still the section listing tech preview to GA requirements, are you trying to say that the Share object creation will now not be a GA requirement? If so, just say that (along with why, if you want, and how/when the Share object will be introduced).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes :) OK let me try to update. Thanks

@aravindhp
Copy link
Contributor

/uncc

@openshift-ci openshift-ci bot removed the request for review from aravindhp November 3, 2021 17:30
@bparees
Copy link
Contributor

bparees commented Nov 4, 2021

/lgtm

@bparees
Copy link
Contributor

bparees commented Nov 4, 2021

/override ci/prow/markdownlint

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 4, 2021

@bparees: Overrode contexts on behalf of bparees: ci/prow/markdownlint

In response to this:

/override ci/prow/markdownlint

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 4, 2021
@bparees
Copy link
Contributor

bparees commented Nov 4, 2021

/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 4, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bparees

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 4, 2021
@openshift-merge-robot openshift-merge-robot merged commit 7786feb into openshift:master Nov 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants