Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update OWNERS: add rvanderp3 #853

Merged
merged 1 commit into from
Jul 30, 2021
Merged

Conversation

fabianofranz
Copy link
Member

Adding Richard Vanderpool, team lead of SPLAT, to the list of approvers.

Adding Richard Vanderpool, team lead of SPLAT, to the list of approvers.
@fabianofranz
Copy link
Member Author

/assign @dhellmann

@fabianofranz
Copy link
Member Author

fyi @kwoodson @rvanderp3

@dhellmann
Copy link
Contributor

I'll approve this with a hold so we can get @rvanderp3's ack.

/approve
/lgtm
/hold

@openshift-ci openshift-ci bot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm Indicates that a PR is ready to be merged. labels Jul 30, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 30, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dhellmann

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 30, 2021
@rvanderp3
Copy link
Contributor

ack!

@sdodson
Copy link
Member

sdodson commented Jul 30, 2021

I think the ack was supposed to be in the form of
/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 30, 2021
@openshift-ci openshift-ci bot merged commit 42209ac into openshift:master Jul 30, 2021
@rvanderp3
Copy link
Contributor

I think the ack was supposed to be in the form of
/hold cancel

Didn't realize that. Thanks @sdodson !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants