Restore tenant configuration for Loki forwarder. #842
Conversation
alanconway
force-pushed
the
forward-to-loki-restore-tenant
branch
2 times, most recently
from
a5141ff
to
f62057c
Compare
| @@ -148,6 +148,12 @@ The following optional output fields are Loki-specific: | |||
| Example: `kubernetes.labels.foo` => `kubernetes_labels_foo`.\ | |||
| **Note**: `kubernetes.host` is *always* be included, even if not requested. | |||
| It is required to ensure ordered label streams. | |||
| - `tenantKey`: (string, default=`"kubernetes.namespaceName"`) \ | |||
There was a problem hiding this comment.
We don't provide a default for in-cluster.
There was a problem hiding this comment.
In addition do we really want to define as tenant key a label key or simply leave it as arbitrary data?
There was a problem hiding this comment.
A fixed tenant ID limits us to static tenants pre-defined by the log admin based on input filters. This has turned out to be inadequate for other cases (JSON, cloudwatch groups etc.), where the logging system needs to respond to new label values or new namespaces appearing in the cluster without a manual re-config each time. I think the same applies to tenants - you can't implement "namespace as tenant" without it unless you know all your namespaces in advance.
alanconway
force-pushed
the
forward-to-loki-restore-tenant
branch
2 times, most recently
from
0a533bf
to
63d9314
Compare
alanconway
force-pushed
the
forward-to-loki-restore-tenant
branch
2 times, most recently
from
7f74862
to
2ada059
Compare
|
@periklis @jcantrill can I get an LGTM here? This brings the enhancement proposal up to date with the code that merged to the CLO. |
This configuration will not be required for our default Loki instance, but may be required for custom Loki instances.
alanconway
force-pushed
the
forward-to-loki-restore-tenant
branch
from
2ada059
to
e147186
Compare
|
/lgtm |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jcantrill The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
This configuration will not be required for our default Loki instance, but may be required for custom Loki instances.
/cc @periklis
/assign @jcantrill