Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Descheduler profiles enhancement to 'implemented' #768

Merged
merged 1 commit into from
May 10, 2021
Merged

Update Descheduler profiles enhancement to 'implemented' #768

merged 1 commit into from
May 10, 2021

Conversation

damemi
Copy link

@damemi damemi commented Apr 30, 2021

No description provided.

damemi
damemi commented Apr 30, 2021
View reviewed changes
Copy link
Author

@damemi damemi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/cc @soltysh @ingvagabund

@damemi damemi force-pushed the update-descheduler-profiles-enhancement branch from 120f623 to a77577d Compare April 30, 2021 17:31
@damemi damemi force-pushed the update-descheduler-profiles-enhancement branch from a77577d to 80f7add Compare May 4, 2021 13:53
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign squeed after the PR has been reviewed.
You can assign the PR to them by writing /assign @squeed in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ingvagabund
Copy link
Member

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label May 5, 2021
soltysh
soltysh approved these changes May 10, 2021
View reviewed changes
Copy link

@soltysh soltysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 10, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: soltysh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 10, 2021
@openshift-merge-robot openshift-merge-robot merged commit 8f10310 into openshift:master May 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ingvagabund ingvagabund ingvagabund left review comments

@soltysh soltysh soltysh approved these changes

@jwforres jwforres Awaiting requested review from jwforres

@kbsingh kbsingh Awaiting requested review from kbsingh

Assignees

@ingvagabund ingvagabund

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@damemi @openshift-ci-robot @ingvagabund @soltysh @openshift-merge-robot