kube-apiserver/audit-policy: document oauth token logging in 4.6+ #684
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sttts
force-pushed
the
sttts-secure-token-audit-logging
branch
2 times, most recently
from
78d8b1a
to
303b14e
Compare
EmilyM1
reviewed
Mar 9, 2021
| and by removing the exception for these resources in the `WriteRequestBodies` and `AllRequestBodies` policies. | ||
| New cluster deployed with 4.6 or later are identified through the `oauth-apiserver.openshift.io/secure-token-storage: true` annotation | ||
| on the `apiservers.config.openshift.io/v1` resource. Old cluster upgraded from 4.5 or older, don't have this annotation and hence do not | ||
| audit log `authaccesstokens` and `oauthauthorizetokens`, not even on metadata level as it is not know whether old, non-sha256 hashed tokens |
There was a problem hiding this comment.
not even on metadata level as it is not know whether old
should read not known
EmilyM1
reviewed
Mar 9, 2021
| @@ -287,6 +311,11 @@ The profile translate like this: | |||
| # catch-all rule to log all other requests with request and response payloads | |||
| - level: RequestResponse | |||
| ``` | |||
|
|
|||
| With secure OAuth storage in-place (compare "Logging of Token with Secure OAuth Storage" section) and | |||
There was a problem hiding this comment.
compare "Logging of Token with Secure OAuth Storage" section
should be
compared to
There was a problem hiding this comment.
it should be a reference. I write "see" instead.
sttts
force-pushed
the
sttts-secure-token-audit-logging
branch
from
303b14e
to
b70991a
Compare
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: EmilyM1, mfojtik The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Documenting openshift/library-go#894 and openshift/cluster-authentication-operator#324.