ingress: Add power-of-two-random-choices enhancement #665
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sgreene570
reviewed
Feb 23, 2021
| ### Goals | ||
|
|
||
| 1. Enable cluster administrators to configure HAProxy to use Power of Two Random Choices. | ||
| 2. Enable application developers configure HAProxy to use Power of Two Random Choices for their Routes. |
There was a problem hiding this comment.
Suggested change
| 2. Enable application developers configure HAProxy to use Power of Two Random Choices for their Routes. | |
| 2. Enable application developers to configure HAProxy to use Power of Two Random Choices for their Routes. |
|
|
||
| ### User Stories | ||
|
|
||
| #### As a cluster administrator, I have an IngressController, it has Routes that update frequently, and I want to traffic to be balanced after a reload. |
There was a problem hiding this comment.
Suggested change
| #### As a cluster administrator, I have an IngressController, it has Routes that update frequently, and I want to traffic to be balanced after a reload. | |
| #### As a cluster administrator, I have an IngressController, it has Routes that update frequently, and I want traffic to be balanced after a reload |
|
|
||
| Using the Power of Two Random Choices may improve balancing in this scenario. | ||
|
|
||
| #### As a cluster administrator, I have a large number of IngressController Pod replicas and a Route with occasional traffic spikes, and I want to ensure that traffic spikes are balanced across the Route's backend servers. |
There was a problem hiding this comment.
Suggested change
| #### As a cluster administrator, I have a large number of IngressController Pod replicas and a Route with occasional traffic spikes, and I want to ensure that traffic spikes are balanced across the Route's backend servers. | |
| #### As a cluster administrator, I have a large number of IngressController Pod replicas and a Route with occasional traffic spikes, and I want to ensure that traffic spikes are balanced across the Route's backend servers |
| If the feature gate is enabled, the operator configures the Deployment by | ||
| specifying "random" for `ROUTER_LOAD_BALANCE_ALGORITHM`, changing the default | ||
| algorithm to Power of Two Random Choices. | ||
|
|
There was a problem hiding this comment.
The router also needs to be changed to allow a random value for the haproxy.router.openshift.io/balance route annotation, right?
Miciah
force-pushed
the
ingress-add-power-of-two-random-choices-enhancement
branch
from
3361e30
to
4125062
Compare
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: knobunc The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
|
/lgtm |
openshift-ci-robot
added
the
do-not-merge/hold
sgreene570
added a commit
to sgreene570/api
that referenced
this pull request
Mar 23, 2021
Add a new feature gate, `PowerOfTwoRandomChoicesBalancing`, that is disabled by default. Enabling this feature gate will tell the OpenShift Router (HAProxy) to use the "Power of Two Random Choices" balancing algorithm by default, in place of the current `leastconn` default balancing algorithm. See https://www.haproxy.com/blog/power-of-two-load-balancing/ as well as openshift/enhancements#665 for more context.
Miciah
force-pushed
the
ingress-add-power-of-two-random-choices-enhancement
branch
from
4125062
to
20637b9
Compare
|
/retest |
|
/lgtm |
|
Never mind; wrong PR. |
|
/lgtm |
openshift-ci-robot
removed
the
do-not-merge/hold
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This enhancement enables cluster administrators to configure ingress to use the "Power of Two Random Choices" balancing algorithm for more even balancing after router reloads.