Skip to content

Commit

Permalink
Merge pull request #650 from mgugino-upstream-stage/co-sched
Browse files Browse the repository at this point in the history
Add ClusterOperator Scheduling
  • Loading branch information
openshift-merge-robot committed May 18, 2021
2 parents dd37ee5 + 8b9f4a8 commit fe57853
Showing 1 changed file with 10 additions and 0 deletions.
10 changes: 10 additions & 0 deletions CONVENTIONS.md
Original file line number Diff line number Diff line change
Expand Up @@ -350,6 +350,12 @@ following taints if doing so is necessary to form a functional Kubernetes node:
Operators should not specify tolerations in their manifests for any of the taints in
the above list without an explicit and credible justification.

Operators should never specify the following toleration:
* `node.kubernetes.io/unschedulable`

Tolerating `node.kubernetes.io/unschedulable` may result in the inability to
drain nodes for upgrade operations.

When an operator configures its operand, the operator likewise may specify
tolerations for the aforementioned taints but should do so only as necessary and only
with explicit justification.
Expand Down Expand Up @@ -383,6 +389,10 @@ spec:
- operator: Exists
```

Tolerating all taints should be reserved for DaemonSets and static
pods only. Tolerating all taints on other types of pods may result in the
inability to drain nodes for upgrade operations.

An example of an operand that matches the first case is kube-proxy, which is required
for services to work. An example of an operand that matches the second case is the
DNS node resolver, which adds an entry to the `/etc/hosts` file on all node hosts so
Expand Down

0 comments on commit fe57853

Please sign in to comment.