LOG-1076: Opt-in cert generation in EO #727
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci
bot
added
the
approved
|
/hold |
openshift-ci
bot
added
the
do-not-merge/hold
ewolinetz
force-pushed
the
es_cert_management
branch
2 times, most recently
from
c372cb4
to
1acca09
Compare
jcantrill
reviewed
Jun 12, 2021
ewolinetz
force-pushed
the
es_cert_management
branch
4 times, most recently
from
78a31d2
to
9c6951b
Compare
|
/hold cancel |
openshift-ci
bot
removed
the
do-not-merge/hold
|
/hold |
openshift-ci
bot
added
the
do-not-merge/hold
|
/test e2e-operator |
|
/retest |
2 similar comments
|
/retest |
|
/retest |
|
/hold |
ewolinetz
force-pushed
the
es_cert_management
branch
2 times, most recently
from
0d61229
to
8ab9d2c
Compare
ewolinetz
force-pushed
the
es_cert_management
branch
from
8ab9d2c
to
14b21c0
Compare
|
/hold cancel |
openshift-ci
bot
removed
the
do-not-merge/hold
|
/retest |
periklis
approved these changes
Jun 18, 2021
Comment on lines
+748
to
+756
| if certOK { | ||
| decodedCert, err := pemDecodeCert(certBytes) | ||
| if err != nil { | ||
| return nil, err | ||
| } | ||
| x509Cert = decodedCert | ||
| } else { | ||
| return nil, fmt.Errorf("missing cert key from secret") | ||
| } |
There was a problem hiding this comment.
nit. Suggest to skip one level of indentation like:
if !certOK {
return nil, fmt.Errorf("missing cert key from secret")
}
decodedCert, err := pemDecodeCert(certBytes)
if err != nil {
return nil, err
}
x509Cert = decodedCertSame applies below for keyOk and SerialOk.
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ewolinetz, periklis The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
cc @rubenvp8510 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
For EO 5.2, adding the ability to opt-in for cert generation and management within EO.
Implementation of enhancement proposal (linked below).
Will also require OAL change to be merged in first since DN Organization and OrganizationUnit were adjusted to read correctly as part of this code change.
To opt in, annotate the
esCR with:To have EO provide a tls cert/key ca-bundle for your component also annotate with:
or
/cc @jcantrill @periklis @jpkrohling
Links