Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

STOR-1400: Add support for Batch DescribeVolume #74

Merged
merged 1 commit into from
Nov 27, 2023

Conversation

jsafrane
Copy link
Contributor

Add --batching=true.

cc @openshift/storage

CI will likely fail until the driver rebase is merged.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Nov 23, 2023
@openshift-ci-robot
Copy link

openshift-ci-robot commented Nov 23, 2023

@jsafrane: This pull request references STOR-1400 which is a valid jira issue.

In response to this:

Add --batching=true.

cc @openshift/storage

CI will likely fail until the driver rebase is merged.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot requested review from gnufied and mpatlasov November 23, 2023 10:15
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 23, 2023
@Phaow
Copy link
Contributor

Phaow commented Nov 24, 2023

/retest

@Phaow
Copy link
Contributor

Phaow commented Nov 24, 2023

/retest-required

1 similar comment
@Phaow
Copy link
Contributor

Phaow commented Nov 24, 2023

/retest-required

Copy link
Contributor

openshift-ci bot commented Nov 24, 2023

@jsafrane: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-csi-extended 2e583bd link false /test e2e-aws-csi-extended

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@Phaow
Copy link
Contributor

Phaow commented Nov 24, 2023

/label qe-approved
CI looks good the e2e-aws-csi-extended 1 failed case caused by driver rebase message change fixed in https://github.com/openshift/openshift-tests-private/pull/12998.

@openshift-ci openshift-ci bot added the qe-approved Signifies that QE has signed off on this PR label Nov 24, 2023
@openshift-ci-robot
Copy link

openshift-ci-robot commented Nov 24, 2023

@jsafrane: This pull request references STOR-1400 which is a valid jira issue.

In response to this:

Add --batching=true.

cc @openshift/storage

CI will likely fail until the driver rebase is merged.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@gnufied
Copy link
Member

gnufied commented Nov 27, 2023

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 27, 2023
Copy link
Contributor

openshift-ci bot commented Nov 27, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gnufied, jsafrane

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit fa1decc into openshift:master Nov 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. qe-approved Signifies that QE has signed off on this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants