-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
STOR-1400: Sync sidecar arguments with upstream #72
Conversation
@jsafrane: This pull request references STOR-1400 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.15.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
f1b2f2f
to
3ebef82
Compare
3ebef82
to
765b084
Compare
/lgtm |
@jsafrane: This pull request references STOR-1400 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.15.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Update the operator to use the same sidecar arguments (timeouts, QPS, worker threads) as upstream. See kubernetes-sigs/aws-ebs-csi-driver#1824 and kubernetes-sigs/aws-ebs-csi-driver#1824.
765b084
to
323d0d0
Compare
Updated external-resizer, it uses |
/retest |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: gnufied, jsafrane The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
@jsafrane: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
[ART PR BUILD NOTIFIER] This PR has been included in build ose-aws-ebs-csi-driver-operator-container-v4.15.0-202311221354.p0.gd4cf1ad.assembly.stream for distgit ose-aws-ebs-csi-driver-operator. |
Update the operator to use the same sidecar arguments (timeouts, QPS, worker threads) as upstream.
See kubernetes-sigs/aws-ebs-csi-driver#1824 and kubernetes-sigs/aws-ebs-csi-driver#1834.
Note that this partially reverts openshift/aws-ebs-csi-driver-operator#248, external-resizer + snapshotter will get
60s
timeout instead of300s
that we have in OCP.cc @openshift/storage