Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

STOR-1400: Sync sidecar arguments with upstream #72

Merged
merged 1 commit into from
Nov 22, 2023

Conversation

jsafrane
Copy link
Contributor

@jsafrane jsafrane commented Nov 21, 2023

Update the operator to use the same sidecar arguments (timeouts, QPS, worker threads) as upstream.

See kubernetes-sigs/aws-ebs-csi-driver#1824 and kubernetes-sigs/aws-ebs-csi-driver#1834.

Note that this partially reverts openshift/aws-ebs-csi-driver-operator#248, external-resizer + snapshotter will get 60s timeout instead of 300s that we have in OCP.

cc @openshift/storage

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Nov 21, 2023
@openshift-ci-robot
Copy link

openshift-ci-robot commented Nov 21, 2023

@jsafrane: This pull request references STOR-1400 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.15.0" version, but no target version was set.

In response to this:

Update the operator to use the same sidecar arguments (timeouts, QPS, worker threads) as upstream.

See kubernetes-sigs/aws-ebs-csi-driver#1824 and kubernetes-sigs/aws-ebs-csi-driver#1824.

Note that this partially reverts openshift/aws-ebs-csi-driver-operator#248, external-resizer + snapshotter will get 60s timeout instead of 300s that we have in OCP.

cc @openshift/storage

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 21, 2023
@gnufied
Copy link
Member

gnufied commented Nov 21, 2023

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 21, 2023
@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD a8ee7ff and 2 for PR HEAD 765b084 in total

@openshift-ci-robot
Copy link

openshift-ci-robot commented Nov 21, 2023

@jsafrane: This pull request references STOR-1400 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.15.0" version, but no target version was set.

In response to this:

Update the operator to use the same sidecar arguments (timeouts, QPS, worker threads) as upstream.

See kubernetes-sigs/aws-ebs-csi-driver#1824 and kubernetes-sigs/aws-ebs-csi-driver#1834.

Note that this partially reverts openshift/aws-ebs-csi-driver-operator#248, external-resizer + snapshotter will get 60s timeout instead of 300s that we have in OCP.

cc @openshift/storage

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Update the operator to use the same sidecar arguments (timeouts, QPS,
worker threads) as upstream.

See kubernetes-sigs/aws-ebs-csi-driver#1824 and
kubernetes-sigs/aws-ebs-csi-driver#1824.
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Nov 21, 2023
@jsafrane
Copy link
Contributor Author

jsafrane commented Nov 21, 2023

Updated external-resizer, it uses -workers= instead of -worker-threads like the other sidecars. Thanks, CI!

@jsafrane
Copy link
Contributor Author

/retest
snapshot tests timed out + hypershift could not install its mgmt cluster due to image registry operator.

@gnufied
Copy link
Member

gnufied commented Nov 21, 2023

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 21, 2023
Copy link
Contributor

openshift-ci bot commented Nov 21, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gnufied, jsafrane

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD a8ee7ff and 2 for PR HEAD 323d0d0 in total

@jsafrane
Copy link
Contributor Author

/retest

Copy link
Contributor

openshift-ci bot commented Nov 22, 2023

@jsafrane: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit d4cf1ad into openshift:master Nov 22, 2023
@openshift-bot
Copy link

[ART PR BUILD NOTIFIER]

This PR has been included in build ose-aws-ebs-csi-driver-operator-container-v4.15.0-202311221354.p0.gd4cf1ad.assembly.stream for distgit ose-aws-ebs-csi-driver-operator.
All builds following this will include this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants