Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

STOR-1850: Rebase to upstream v1.15.0 for OCP 4.17 #11

Merged
merged 103 commits into from
Aug 5, 2024

Conversation

dependabot bot and others added 30 commits January 29, 2024 02:43
Bumps build-image/debian-base from bookworm-v1.0.0 to bookworm-v1.0.1.

---
updated-dependencies:
- dependency-name: build-image/debian-base
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
…docker/cmd/smbplugin/build-image/debian-base-bookworm-v1.0.1

chore(deps): bump build-image/debian-base from bookworm-v1.0.0 to bookworm-v1.0.1 in /cmd/smbplugin
fix: delete volume failure in archive mode when subDir contains /
…-registrar-image

fix: change node-driver-registrar image version to 2.10.0 (deploy/v1.14.0 manifests)
Bumps [golangci/golangci-lint-action](https://github.com/golangci/golangci-lint-action) from 3 to 4.
- [Release notes](https://github.com/golangci/golangci-lint-action/releases)
- [Commits](golangci/golangci-lint-action@v3...v4)

---
updated-dependencies:
- dependency-name: golangci/golangci-lint-action
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
…github_actions/golangci/golangci-lint-action-4

chore(deps): bump golangci/golangci-lint-action from 3 to 4
…tion-test

cleanup: remove integration test
Bumps [k8s.io/component-base](https://github.com/kubernetes/component-base) from 0.28.6 to 0.28.7.
- [Commits](kubernetes/component-base@v0.28.6...v0.28.7)

---
updated-dependencies:
- dependency-name: k8s.io/component-base
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
fix

fix

fix

fix
…go_modules/k8s.io/component-base-0.28.7

chore(deps): bump k8s.io/component-base from 0.28.6 to 0.28.7
Bumps [k8s.io/pod-security-admission](https://github.com/kubernetes/pod-security-admission) from 0.28.6 to 0.28.7.
- [Commits](kubernetes/pod-security-admission@v0.28.6...v0.28.7)

---
updated-dependencies:
- dependency-name: k8s.io/pod-security-admission
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
…go_modules/k8s.io/pod-security-admission-0.28.7

chore(deps): bump k8s.io/pod-security-admission from 0.28.6 to 0.28.7
Bumps [k8s.io/mount-utils](https://github.com/kubernetes/mount-utils) from 0.29.1 to 0.29.2.
- [Commits](kubernetes/mount-utils@v0.29.1...v0.29.2)

---
updated-dependencies:
- dependency-name: k8s.io/mount-utils
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
…go_modules/k8s.io/mount-utils-0.29.2

chore(deps): bump k8s.io/mount-utils from 0.29.1 to 0.29.2
Bumps [github.com/golang/protobuf](https://github.com/golang/protobuf) from 1.5.3 to 1.5.4.
- [Release notes](https://github.com/golang/protobuf/releases)
- [Commits](golang/protobuf@v1.5.3...v1.5.4)

---
updated-dependencies:
- dependency-name: github.com/golang/protobuf
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
…go_modules/github.com/golang/protobuf-1.5.4

chore(deps): bump github.com/golang/protobuf from 1.5.3 to 1.5.4
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 23, 2024
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 23, 2024
@dfajmon dfajmon changed the title STOR-1850: Rebase to upstream v1.14.0 for OCP 4.17 STOR-1850: Rebase to upstream v1.15.0 for OCP 4.17 Jul 23, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jul 23, 2024

@dfajmon: This pull request references STOR-1850 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.17.0" version, but no target version was set.

In response to this:

Diff to upstream v1.15.0:
kubernetes-csi/csi-driver-smb@v1.15.0...dfajmon:rebase-1.14.0

Changes between 1.14.0 (OCP 4.16) and 1.15.0 (OCP 4.17):

Full changelogs:
https://github.com/kubernetes-csi/csi-driver-smb/releases/tag/v1.14.0

@openshift/storage

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Copy link

openshift-ci bot commented Jul 23, 2024

@dfajmon: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/security 8e26a1e link false /test security

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Jul 23, 2024

@dfajmon: This pull request references STOR-1850 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.17.0" version, but no target version was set.

In response to this:

Diff to upstream v1.15.0:
kubernetes-csi/csi-driver-smb@v1.15.0...dfajmon:rebase-1.14.0

Changes between 1.13.0 (OCP 4.16) and 1.15.0 (OCP 4.17):

Full changelogs:
https://github.com/kubernetes-csi/csi-driver-smb/releases/tag/v1.14.0
https://github.com/kubernetes-csi/csi-driver-smb/releases/tag/v1.15.0

@openshift/storage

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@dfajmon
Copy link
Author

dfajmon commented Jul 23, 2024

@mpatlasov newly rebased with the tag 1.15.0
/unhold

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 23, 2024
@dfajmon
Copy link
Author

dfajmon commented Jul 23, 2024

/docs-approved
/px-approved

@mpatlasov
Copy link

/lgtm
/approve
/label docs-approved
/label px-approved

Great job, thank you!

@openshift-ci openshift-ci bot added docs-approved Signifies that Docs has signed off on this PR px-approved Signifies that Product Support has signed off on this PR labels Jul 24, 2024
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 24, 2024
Copy link

openshift-ci bot commented Jul 24, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dfajmon, mpatlasov

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 24, 2024
@Phaow
Copy link

Phaow commented Aug 5, 2024

/label qe-approved
Pre merge test passed with manually build driver image with the PR:

$ oc rsh -c csi-driver smb-csi-driver-controller-5bb444444c-9zggf
sh-5.1# /bin/smbplugin --ver
Build Date: "2024-08-05T07:30:37Z"
Compiler: gc
Driver Name: smb.csi.k8s.io
Driver Version: v1.15.0
Git Commit: 8e26a1e4b731fab822f45a9d2766c34c02f17eb8
Go Version: go1.22.5 (Red Hat 1.22.5-1.el9) X:strictfipsruntime
Platform: linux/amd64

# E2E Regression tests all looks good
$ go test -v -timeout=0 ./test/e2e
Ran 12 of 13 Specs in 323.231 seconds
SUCCESS! -- 12 Passed | 0 Failed | 0 Pending | 1 Skipped

@openshift-ci openshift-ci bot added the qe-approved Signifies that QE has signed off on this PR label Aug 5, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Aug 5, 2024

@dfajmon: This pull request references STOR-1850 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.17.0" version, but no target version was set.

In response to this:

Diff to upstream v1.15.0:
kubernetes-csi/csi-driver-smb@v1.15.0...dfajmon:rebase-1.14.0

Changes between 1.13.0 (OCP 4.16) and 1.15.0 (OCP 4.17):

Full changelogs:
https://github.com/kubernetes-csi/csi-driver-smb/releases/tag/v1.14.0
https://github.com/kubernetes-csi/csi-driver-smb/releases/tag/v1.15.0

@openshift/storage

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-merge-bot openshift-merge-bot bot merged commit 0161a3a into openshift:master Aug 5, 2024
5 of 6 checks passed
@openshift-bot
Copy link

[ART PR BUILD NOTIFIER]

Distgit: ose-smb-csi-driver
This PR has been included in build ose-smb-csi-driver-container-v4.17.0-202408051016.p0.g0161a3a.assembly.stream.el9.
All builds following this will include this PR.

@dfajmon dfajmon deleted the rebase-1.14.0 branch September 3, 2024 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. docs-approved Signifies that Docs has signed off on this PR jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. px-approved Signifies that Product Support has signed off on this PR qe-approved Signifies that QE has signed off on this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.