Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add VMs to Inventory card #1883

Merged
merged 1 commit into from
Jul 9, 2019
Merged

Add VMs to Inventory card #1883

merged 1 commit into from
Jul 9, 2019

Conversation

rawagner
Copy link
Contributor

@rawagner rawagner commented Jul 2, 2019 •
edited
Loading

depends on #1871

inventory_vm

@openshift-ci-robot openshift-ci-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Jul 2, 2019
@rawagner rawagner force-pushed the kubevirt-inventory branch from 93171ed to 26667d3 Compare July 2, 2019 10:13
@spadgett spadgett added this to the v4.2 milestone Jul 2, 2019
@rawagner rawagner force-pushed the kubevirt-inventory branch from 26667d3 to bdf04ea Compare July 3, 2019 09:24
@openshift-ci-robot openshift-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Jul 3, 2019
@vojtechszocs
Copy link
Contributor

depends on #1871

Also #1911 - apologies for the breakage due to plugin-stats script.

@rawagner rawagner force-pushed the kubevirt-inventory branch 2 times, most recently from 9ed820c to 8caec4e Compare July 4, 2019 14:03
@openshift-ci-robot openshift-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 8, 2019
@rawagner rawagner force-pushed the kubevirt-inventory branch from 8caec4e to 2d4936c Compare July 8, 2019 17:53
@openshift-ci-robot openshift-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 8, 2019
@atiratree
Copy link
Member

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 9, 2019
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rawagner, suomiy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 7f27238 into openshift:master Jul 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jhadvig jhadvig Awaiting requested review from jhadvig

@spadgett spadgett Awaiting requested review from spadgett

Assignees

@atiratree atiratree

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v4.2
Development

Successfully merging this pull request may close these issues.
6 participants
@rawagner @vojtechszocs @atiratree @openshift-ci-robot @spadgett @openshift-merge-robot