Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1720161: Avoid overlapping text in machine config list #1713

Merged
merged 1 commit into from
Jul 2, 2019
Merged

Bug 1720161: Avoid overlapping text in machine config list #1713

merged 1 commit into from
Jul 2, 2019

Conversation

spadgett
Copy link
Member

@spadgett spadgett commented Jun 13, 2019 •
edited
Loading

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1720161

This is fixed in 4.2 by #1666.

/assign @rhamilto
/hold

Machine Configs · OKD 2019-06-13 08-27-32

@spadgett spadgett added this to the v4.1.z milestone Jun 13, 2019
@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 13, 2019
@openshift-ci-robot
Copy link
Contributor

@spadgett: This pull request references an invalid Bugzilla bug:

  • expected the bug to target the "4.1.z" release, but it targets "---" instead

In response to this:

Bug 1720161: Avoid overlapping text in machine config list

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Jun 13, 2019
@openshift-ci-robot openshift-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Jun 13, 2019
@openshift-ci-robot
Copy link
Contributor

@spadgett: This pull request references a valid Bugzilla bug.

In response to this:

Bug 1720161: Avoid overlapping text in machine config list

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot removed the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Jun 13, 2019
jhadvig
jhadvig approved these changes Jun 13, 2019
View reviewed changes
Copy link
Member

@jhadvig jhadvig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jun 13, 2019
@eparis
Copy link
Member

eparis commented Jun 24, 2019

There does not appear to be a bugzilla associated with the with parent PR. Thus we have no verification that the fix worked. Without VERIFIED status on a 4.2 bug (associated with #1666) I can not approve this PR.

@spadgett
Copy link
Member Author

spadgett commented Jun 24, 2019 •
edited by eparis
Loading

Created https://bugzilla.redhat.com/show_bug.cgi?id=1723531 for 4.2 verification

@spadgett
Copy link
Member Author

/hold cancel

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 24, 2019
@eparis
Copy link
Member

eparis commented Jun 25, 2019

The parent PR did not get QE review. Will re-check next week.

@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dtaylor113, jhadvig, spadgett

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jwforres
Copy link
Member

jwforres commented Jul 2, 2019

QE validated the 4.2 BZ so I'm approving for this week

@jwforres jwforres added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Jul 2, 2019
@openshift-merge-robot openshift-merge-robot merged commit 47532dc into openshift:release-4.1 Jul 2, 2019
@spadgett spadgett deleted the machine-config-wrap branch July 2, 2019 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jhadvig jhadvig jhadvig approved these changes

@dtaylor113 dtaylor113 dtaylor113 approved these changes

Assignees

@rhamilto rhamilto

@jhadvig jhadvig

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v4.1.z
Development

Successfully merging this pull request may close these issues.
8 participants
@spadgett @openshift-ci-robot @eparis @jwforres @jhadvig @dtaylor113 @rhamilto @openshift-merge-robot