-
Notifications
You must be signed in to change notification settings - Fork 618
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug 2022502: Remove old table class overrides causing display issue. #10443
Bug 2022502: Remove old table class overrides causing display issue. #10443
Conversation
@sg00dwin: This pull request references Bugzilla bug 2022502, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@sg00dwin This is a good change, but I think we need to look at all of the overrides. I suspect we'll run into other issues bringing the PF applications into console as plugins. Let's go ahead with this fix for now, but we should open a follow up issue. cc @jamestalton |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sg00dwin, spadgett The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@sg00dwin: All pull requests linked via external trackers have merged: Bugzilla bug 2022502 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Fixes 2022502
These css override classes should no longer be needed.
They where introduced awhile ago when virtualized lists were converted to @patternfly/react-tables and @patternfly/react-virtualization-extension. #1465
PatternFly virtualized tables with checkbox columns, should rely on a parent div class
.pf-c-scrollablegrid .pf-c-table .pf-c-table__check
to apply these rules in this scenario.https://github.com/patternfly/patternfly-react/blob/82faf387f8c171cd66a22efcd1f22afb8499a69b/packages/react-virtualized-extension/src/components/Virtualized/examples/VirtualGrid.example.css#L20-L28