NO-JIRA: Fix upstream and OKD builds #1222
Conversation
PR openshift#1099 broke upstream and OKD builds as it added a dependency on rsync. quay.io/centos/centos:stream9 image does not ship rsync by default. Once we can use the new golang's recursive copy (CopyFS) functionality in go 1.23 (golang/go#62484), use it and remove the dependency on rsync.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jmencak The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
jmencak
changed the title
openshift-ci-robot
added
the
jira/valid-reference
|
@jmencak: This pull request explicitly references no jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
Infra issues |
|
/retest |
|
There is no way this change can cause hypershift test failures |
|
/joke |
|
@jmencak: Hear about the new restaurant called Karma? There’s no menu: You get what you deserve. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/retest |
|
/lgtm |
|
/label acknowledge-critical-fixes-only |
openshift-ci
bot
added
the
acknowledge-critical-fixes-only
|
There is no way adding a dependency "rsync" can cause hypershift test failures. We need this. I've seen the "Failed to get *v1beta1.HostedCluster: client rate limiter Wait returned an error: context deadline exceeded" in other PRs that finally merged. /override ci/prow/e2e-hypershift |
|
/retest |
|
/override ci/prow/e2e-hypershift |
|
@jmencak: Overrode contexts on behalf of jmencak: ci/prow/e2e-hypershift In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@jmencak: Overrode contexts on behalf of jmencak: ci/prow/e2e-hypershift In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@jmencak: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
[ART PR BUILD NOTIFIER] Distgit: cluster-node-tuning-operator |
PR #1099 broke upstream and OKD builds as it added a dependency on rsync. quay.io/centos/centos:stream9 image does not ship rsync by default.
Once we can use the new golang's recursive copy (CopyFS) functionality in go 1.23 (golang/go#62484), use it and remove the dependency on rsync.