Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use protobuf if possible for core kubernetes clients #2505

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

vrutkovs
Copy link
Member

Protobuf is more efficient comparing to JSON, but it cannot yet be used for custom types

  • I added CHANGELOG entry for this change.
  • No user facing changes, so no entry in CHANGELOG was needed.

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 23, 2024
Copy link
Contributor

openshift-ci bot commented Oct 23, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

Copy link
Contributor

openshift-ci bot commented Oct 23, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: vrutkovs
Once this PR has been reviewed and has the lgtm label, please assign rexagod for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Contributor

openshift-ci bot commented Oct 23, 2024

@vrutkovs: This PR was included in a payload test run from openshift/kubernetes#2121
trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-release-master-nightly-4.18-e2e-aws-ovn-serial

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/8ead4490-9117-11ef-8662-fdd14cd693cb-0

Copy link
Contributor

openshift-ci bot commented Oct 23, 2024

@vrutkovs: This PR was included in a payload test run from openshift/kubernetes#2121
trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-release-master-nightly-4.18-e2e-aws-ovn-serial

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/17dde510-911a-11ef-90f7-2ad72545de28-0

Copy link
Contributor

openshift-ci bot commented Oct 23, 2024

@vrutkovs: This PR was included in a payload test run from openshift/kubernetes#2121
trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-release-master-nightly-4.18-e2e-aws-ovn-serial

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/7bfd8c40-9150-11ef-90f9-776d17dfc394-0

Copy link
Contributor

openshift-ci bot commented Oct 23, 2024

@vrutkovs: This PR was included in a payload test run from openshift/kubernetes#2121
trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-release-master-nightly-4.18-e2e-aws-ovn-serial

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/f2b93120-9157-11ef-92ee-3ba7dedfccf7-0

Copy link
Contributor

openshift-ci bot commented Oct 24, 2024

@vrutkovs: This PR was included in a payload test run from openshift/kubernetes#2121
trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-release-master-nightly-4.18-e2e-aws-ovn-serial

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/9f7b0780-91d0-11ef-801e-f8298112fd81-0

Copy link
Contributor

openshift-ci bot commented Oct 25, 2024

@vrutkovs: This PR was included in a payload test run from openshift/kubernetes#2121
trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-release-master-nightly-4.18-e2e-aws-ovn-serial

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/b4572c50-92c1-11ef-9dc8-8ee5ecca121f-0

Copy link
Contributor

openshift-ci bot commented Oct 25, 2024

@vrutkovs: This PR was included in a payload test run from openshift/kubernetes#2121
trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-release-master-nightly-4.18-e2e-aws-ovn-serial

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/31391bc0-92ef-11ef-8a0e-563ed35e32a0-0

Copy link
Contributor

openshift-ci bot commented Oct 29, 2024

@vrutkovs: This PR was included in a payload test run from openshift/kubernetes#2124
trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-release-master-nightly-4.18-e2e-aws-ovn-serial

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/fd0725a0-960d-11ef-9b20-c6c69022f342-0

Copy link
Contributor

openshift-ci bot commented Oct 30, 2024

@vrutkovs: This PR was included in a payload test run from openshift/kubernetes#2124
trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-release-master-nightly-4.18-e2e-aws-ovn-serial

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/081fe680-96da-11ef-91f4-cde4735e474b-0

Copy link
Contributor

openshift-ci bot commented Oct 30, 2024

@vrutkovs: This PR was included in a payload test run from openshift/kubernetes#2124
trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-release-master-nightly-4.18-e2e-aws-ovn-serial

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/a7c78740-96f5-11ef-8917-56e896fcf5d0-0

Copy link
Contributor

openshift-ci bot commented Oct 31, 2024

@vrutkovs: This PR was included in a payload test run from openshift/kubernetes#2124
trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-release-master-nightly-4.18-e2e-aws-ovn-serial

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/20169390-9790-11ef-9369-5b6a6b14fab2-0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant