Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin Jsonnet versions for release 4.11 #1693

Merged
merged 1 commit into from
Jun 20, 2022

Conversation

raptorsun
Copy link
Contributor

  • I added CHANGELOG entry for this change.
  • No user facing changes, so no entry in CHANGELOG was needed.

This PR pins down versions of Jsonnet dependencies, preparing release 4.11.

@openshift-ci openshift-ci bot requested review from jan--f and sthaha June 17, 2022 16:58
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 17, 2022
@raptorsun
Copy link
Contributor Author

/test e2e-agnostic-upgrade

Copy link
Contributor

@simonpasquier simonpasquier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one small nit otherwise lgtm

@@ -8,7 +8,7 @@
"subdir": "contrib/mixin"
}
},
"version": "main"
"version": "release-3.5"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMHO we should make an exception for etcd otherwise we would lose improvements on the etcd dashboards. AFAICT the release-4.10 branch uses main too + we have a plan to move the etcd dashboards to the cluster-etcd operator anyway.

Signed-off-by: Haoyu Sun <hasun@redhat.com>
@simonpasquier
Copy link
Contributor

/skip
/lgtm

@simonpasquier
Copy link
Contributor

/retest

@simonpasquier
Copy link
Contributor

/label docs-approved
/label qe-approved
/label px-approved

This is locking our jsonnet dependencies to the release branches and introduces no functional change to CMO assets.

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 20, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 20, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: raptorsun, simonpasquier

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [raptorsun,simonpasquier]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added docs-approved Signifies that Docs has signed off on this PR qe-approved Signifies that QE has signed off on this PR px-approved Signifies that Product Support has signed off on this PR labels Jun 20, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 20, 2022

@raptorsun: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-single-node d7d77d8 link false /test e2e-aws-single-node

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-ci openshift-ci bot merged commit 55e050f into openshift:master Jun 20, 2022
@raptorsun raptorsun deleted the release-4.11-jsonnet branch June 20, 2022 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. docs-approved Signifies that Docs has signed off on this PR lgtm Indicates that a PR is ready to be merged. px-approved Signifies that Product Support has signed off on this PR qe-approved Signifies that QE has signed off on this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants