-
Notifications
You must be signed in to change notification settings - Fork 363
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pin Jsonnet versions for release 4.11 #1693
Conversation
/test e2e-agnostic-upgrade |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
one small nit otherwise lgtm
jsonnet/jsonnetfile.json
Outdated
@@ -8,7 +8,7 @@ | |||
"subdir": "contrib/mixin" | |||
} | |||
}, | |||
"version": "main" | |||
"version": "release-3.5" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IMHO we should make an exception for etcd otherwise we would lose improvements on the etcd dashboards. AFAICT the release-4.10 branch uses main
too + we have a plan to move the etcd dashboards to the cluster-etcd operator anyway.
Signed-off-by: Haoyu Sun <hasun@redhat.com>
cf5bffd
to
d7d77d8
Compare
/skip |
/retest |
/label docs-approved This is locking our jsonnet dependencies to the release branches and introduces no functional change to CMO assets. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: raptorsun, simonpasquier The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@raptorsun: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
This PR pins down versions of Jsonnet dependencies, preparing release 4.11.