[bot] Update jsonnet dependencies #1647
Conversation
![openshift-monitoring-bot[bot]](https://avatars.githubusercontent.com/in/142888?s=60&v=4){kind=small}
openshift-ci
bot
added
the
needs-ok-to-test
|
Hi @openshift-monitoring-bot[bot]. Thanks for your PR. I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/ok-to-test |
openshift-ci
bot
added
ok-to-test
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jan--f, openshift-monitoring-bot[bot] The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
lgtm
monitoring-commit-bot
bot
force-pushed
the
automated-updates-master-update-generate
branch
from
a59a087 to
85b55ea
Compare
|
New changes are detected. LGTM label has been removed. |
monitoring-commit-bot
bot
force-pushed
the
automated-updates-master-update-generate
branch
from
85b55ea to
83f3816
Compare
| expr: | | ||
| ( | ||
| node_filesystem_avail_bytes{job="node-exporter",fstype!=""} / node_filesystem_size_bytes{job="node-exporter",fstype!=""} * 100 < 5 | ||
| node_filesystem_avail_bytes{job="node-exporter",fstype!=""} / node_filesystem_size_bytes{job="node-exporter",fstype!=""} * 100 < 3 |
There was a problem hiding this comment.
hmm the change comes from prometheus/node_exporter#2352 which is supposed to fix the critical/warning thresholds, not sure why we get the opposite result 🤔
There was a problem hiding this comment.
Not the opposite result, but exactly what the code says :)
https://github.com/prometheus/node_exporter/blob/7fc5c6045aeb1d615296f6daca1f7a77554d5efb/docs/node-mixin/config.libsonnet#L52-L53
There was a problem hiding this comment.
There was a problem hiding this comment.
🤦♂️ the thresholds are swapped in mixin config. Thanks for the PR :)
monitoring-commit-bot
bot
force-pushed
the
automated-updates-master-update-generate
branch
2 times, most recently
from
1db07cb to
293caff
Compare
|
/skip |
monitoring-commit-bot
bot
force-pushed
the
automated-updates-master-update-generate
branch
from
293caff to
01ed967
Compare
|
/retest |
1 similar comment
|
/retest |
monitoring-commit-bot
bot
force-pushed
the
automated-updates-master-update-generate
branch
from
01ed967 to
307c189
Compare
|
/retest |
monitoring-commit-bot
bot
force-pushed
the
automated-updates-master-update-generate
branch
from
307c189 to
e6edca0
Compare
|
Needs one more update, prometheus/node_exporter#2373 merged 1 day after the last bot push. |
monitoring-commit-bot
bot
force-pushed
the
automated-updates-master-update-generate
branch
from
e6edca0 to
0d35cc9
Compare
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
monitoring-commit-bot
bot
force-pushed
the
automated-updates-master-update-generate
branch
from
0d35cc9 to
b4546e2
Compare
|
@openshift-monitoring-bot[bot]: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/close |
openshift-ci
bot
added
the
needs-rebase
|
@openshift-monitoring-bot[bot]: PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@simonpasquier: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Description
This pull request updates all jsonnet dependencies listed in
jsonnet/jsonnetfile.jsonto their latest versions and regenerates all assets.If you wish to perform this manually, execute the following commands from the cluster-monitoring-operator repository: