-
Notifications
You must be signed in to change notification settings - Fork 127
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug 1788231: pkg/cmd/render: improve IPv6 support #52
Conversation
This is currently totally blocking IPv6-on-4.4 testing so it would be good to get it in soon even if it's not perfect yet. |
/hold this still needs testing |
But as dan noted it is blocking |
d51d8f9
to
94e80a1
Compare
@hexfusion: This pull request references Bugzilla bug 1788231, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@hexfusion: This pull request references Bugzilla bug 1788231, which is valid. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/hold cancel |
/retest |
/test e2e-aws using payload for manual testing |
What needs to be done to get this to merge? If parts of it are not ready, is it possible to split out just the "make IPv6 work" part without any of the refactoring and get that merged? This is currently blocking us from being able to have IPv6 CI on 4.4. (It's not the only thing blocking that, or else @eparis would be standing over your shoulder asking "are we there yet?" over and over until you merged, but it will soon be the only bug that we know of that blocks IPv6 CI.) |
point taken :), will resolve today. |
Signed-off-by: Sam Batschelet <sbatsche@redhat.com>
I doubt this works in a week. /lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: deads2k, hexfusion The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
@danwinship this solves some but not all the problems. we need this anyway so consider this a down payment. |
/retest Please review the full test history for this PR and help us cut down flakes. |
13 similar comments
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
@hexfusion: All pull requests linked via external trackers have merged. Bugzilla bug 1788231 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@hexfusion: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Second iteration of IPv6 support includes a refactor of render and improved unit tests.