UPSTREAM: <carry> Add standard Makefile targets #37
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: Nolan Brubaker <nolan@nbrubaker.com>
|
@nrb: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
| @@ -0,0 +1,30 @@ | |||
| #!/bin/bash | |||
There was a problem hiding this comment.
Probably don't want this one, this was a strict experiment with CPMS and would probably not be appropriate for a forked repository.
The idea is that all log keys in the structured logs are camelCase but, I don't even know if this project uses structured logs
| @@ -41,6 +41,7 @@ func TestCACacheVerify(t *testing.T) { | |||
| } | |||
| }) | |||
| for desc, invalidCert := range ca.invalidCerts { | |||
| invalidCert := invalidCert | |||
There was a problem hiding this comment.
Should this be in this pull request? Or is this from something else you are working on.
There was a problem hiding this comment.
It's to make verification pass - the loop variable was being captured, which caused linting failures.
| VERSION ?= $(shell git describe --always --abbrev=7) | ||
| MUTABLE_TAG ?= latest | ||
| IMAGE ?= gcp-cloud-controller-manager | ||
| BUILD_IMAGE ?= registry.ci.openshift.org/openshift/release:golang-1.20 |
|
I'm going to close this out, since kubernetes#590 is opened upstream. |
These Makefile targets should make building and CI easier.