Update golint configuration #3502
Conversation
- Use a container for running golangci-lint outside of CI, this fixes problems where a developer is running a different version of go or golangci-lint than CI. - Use errorlint built in linter instead of the direct vendored version
|
Using the wrong version of golangci-lint crashed my machine using all 64 GB of RAM. /lgtm |
|
also thanks @stbenjam ! |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dgoodwin, smg247, stbenjam The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
@stbenjam: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Use a container for running golangci-lint outside of CI, this fixes problems where a developer is running a different version of go or golangci-lint than CI (e.g. avoids problems like Excessive memory usage golangci/golangci-lint#3565)
Use errorlint built in linter instead of the direct vendored version