CMP-2639: Exclude binary libcrypto check using golang 1.22 #205
Conversation
Golang version 1.22 does not have hardcoded libcrypto versions anymore, and does not emit the libcrypto version in the binary output of a go binary (e.g., using strings). Because of this, the approach we were using to detect the OpenSSL version based on a regular expression and attempting to match that with the binary output does not work for binaries built with golang 1.22. This is particularly prevalent with OpenShift 4.17 payloads that are using RHEL 9 and golang 1.22 base images. This commit updates the binary scan logic to skip checking binaries for OpenSSL versions when using golang 1.22.
openshift-ci-robot
added
the
jira/valid-reference
|
@rhmdnd: This pull request references CMP-2639 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.17.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-ci
bot
added
the
approved
|
@rhmdnd: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mrunalp, rhmdnd The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Golang version 1.22 does not have hardcoded libcrypto versions anymore, and does not emit the libcrypto version in the binary output of a go binary (e.g., using strings).
Because of this, the approach we were using to detect the OpenSSL version based on a regular expression and attempting to match that with the binary output does not work for binaries built with golang 1.22.
This is particularly prevalent with OpenShift 4.17 payloads that are using RHEL 9 and golang 1.22 base images.
This commit updates the binary scan logic to skip checking binaries for OpenSSL versions when using golang 1.22.