Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[OSSM-6411] Ignore rhel9 binary in rhel8 istio-cni image #203

Merged
merged 1 commit into from
Jun 27, 2024

Conversation

asmigala
Copy link
Contributor

We are building a rhel8-based image that includes both rhel8 and rhel9 cni binary and copies the correct one to the node at runtime. See https://issues.redhat.com/browse/OSSM-6411 for details

@asmigala asmigala force-pushed the ossm-6411-rhel9-binary branch from cde3db4 to 639fd2f Compare June 27, 2024 13:38
@asmigala asmigala changed the title [OSSM-6411] Ignore rhel9 binary in rhel8 isito-cni image [OSSM-6411] Ignore rhel9 binary in rhel8 istio-cni image Jun 27, 2024
@openshift-ci openshift-ci bot requested review from kolyshkin and rhmdnd June 27, 2024 13:42
@rphillips
Copy link
Contributor

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 27, 2024
Copy link
Contributor

openshift-ci bot commented Jun 27, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: asmigala, rphillips

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 27, 2024
Copy link
Contributor

openshift-ci bot commented Jun 27, 2024

@asmigala: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit e7744cb into openshift:main Jun 27, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants