Fix OS scan when -V is not set

[rphillips]

This PR warns when the os cannot be figured out without the -V option. The default config does not have a valid OS distribution set, since it is version specific.

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rphillips

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [rphillips]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[ashwindasr]

cd (certified distributions) was returning an empty list [] if -V is not set. This PR aims to fix that by failing with a new error (certified_distributions is not defined, please use -V [VERSION] on the command line). For example:

asdas@asdas-thinkpadp1gen3:~/GolandProjects/check-payload$ sudo ./check-payload scan image --spec registry-proxy.engineering.redhat.com/rh-osbs/openshift-ose-pod-rhel9@sha256:856bcc5a915f5af7dd6bfb35faa54ecb78e350c4ca5adb01d49df8915d3bb258
...
---- Failure Report
+------------------------------------+---------------------+-------------------------------------------------------------------------------------+-----------------------------------------------------------------------------------------------------------------------------------------------+
| OPERATOR NAME                      | EXECUTABLE NAME     | STATUS                                                                              | IMAGE                                                                                                                                         |
+------------------------------------+---------------------+-------------------------------------------------------------------------------------+-----------------------------------------------------------------------------------------------------------------------------------------------+
| openshift-enterprise-pod-container | /etc/redhat-release | certified_distributions is not defined, please use -V [VERSION] on the command line | registry-proxy.engineering.redhat.com/rh-osbs/openshift-ose-pod-rhel9@sha256:856bcc5a915f5af7dd6bfb35faa54ecb78e350c4ca5adb01d49df8915d3bb258 |
+------------------------------------+---------------------+-------------------------------------------------------------------------------------+-----------------------------------------------------------------------------------------------------------------------------------------------+

[ashwindasr]

also looks like verify is failing, we may need to add

"ErrCertifiedDistributionsEmpty": ErrCertifiedDistributionsEmpty,

to internal/types/error_map.go

[kolyshkin]

Looks like the first two commits needs to be squashed?

[rphillips]

Squashed and fix upped the comments.

[openshift-ci]

@rphillips: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[ashwindasr]

/lgtm