Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update excludes #176

Merged
merged 3 commits into from
May 7, 2024
Merged

Update excludes #176

merged 3 commits into from
May 7, 2024

Conversation

ashwindasr
Copy link
Contributor

@ashwindasr ashwindasr commented Apr 25, 2024 •
edited
Loading

Update excludes to reduce false positives

4.16:
ose-installer-container: Dockerfile
ose-installer-altinfra-container: Dockerfile
ose-installer-terraform-providers-container: Dockerfile
ib-sriov-cni-container: Dockerfile
openshift-enterprise-operator-sdk-container: Dockerfile
ose-cloud-credential-operator-container: Dockerfile
ose-egress-router-cni-container: Dockerfile
ose-machine-config-operator-container: Dockerfile
sriov-cni-container: Dockerfile

4.15:
ib-sriov-cni-container: Dockerfile
openshift-enterprise-operator-sdk-container: Dockerfile

4.14:
openshift-enterprise-operator-sdk-container: Dockerfile

4.13:
openshift-enterprise-operator-sdk-container: Dockerfile

@openshift-ci openshift-ci bot requested review from kolyshkin and rhmdnd April 25, 2024 21:12
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 30, 2024
@ashwindasr ashwindasr changed the title Excludes for ose-installer-altinfra-container and ose-installer-container Update excludes May 7, 2024
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 7, 2024
@ashwindasr
Copy link
Contributor Author

/label tide/merge-method-squash

@openshift-ci openshift-ci bot added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label May 7, 2024
@ashwindasr
Copy link
Contributor Author

/remove-label tide/merge-method-squash

@openshift-ci openshift-ci bot removed the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label May 7, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented May 7, 2024

@ashwindasr: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@rphillips
Copy link
Contributor

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 7, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented May 7, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ashwindasr, rphillips

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 7, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 14b3abc into openshift:main May 7, 2024
5 checks passed
@ashwindasr ashwindasr deleted the update-exludes branch May 7, 2024 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kolyshkin kolyshkin Awaiting requested review from kolyshkin

@rhmdnd rhmdnd Awaiting requested review from rhmdnd

Assignees

@rphillips rphillips

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ashwindasr @rphillips @openshift-merge-robot