Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add exceptions for OpenShift Virtualisation #174

Merged
merged 1 commit into from
Apr 25, 2024

Conversation

dominikholler
Copy link
Contributor

No description provided.

@openshift-ci openshift-ci bot requested review from kolyshkin and mrunalp April 23, 2024 15:13
@rphillips
Copy link
Contributor

rphillips commented Apr 23, 2024

@dominikholler Can you provide a link to the dockerfiles?

Copy link
Contributor

@kolyshkin kolyshkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dominikholler perhaps it's better to add this into global config instead? This will result in 4x decrease in amount of lines added :)

Signed-off-by: Dominik Holler <dholler@redhat.com>
@dominikholler
Copy link
Contributor Author

@dominikholler perhaps it's better to add this into global config instead? This will result in 4x decrease in amount of lines added :)

Thanks, I did not recognize that this is possible before!

Copy link
Contributor

openshift-ci bot commented Apr 24, 2024

@dominikholler: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@rphillips
Copy link
Contributor

/lgtm
/assign @rhmdnd

Copy link
Contributor

openshift-ci bot commented Apr 24, 2024

@rphillips: GitHub didn't allow me to assign the following users: rhmdnd.

Note that only openshift members with read permissions, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

/lgtm
/assign @rhmdnd

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 24, 2024
Copy link
Contributor

@kolyshkin kolyshkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

openshift-ci bot commented Apr 25, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dominikholler, kolyshkin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 25, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit fd150c4 into openshift:main Apr 25, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants