OCPBUGS-24612: check for goexperimental >= 1.18

[rphillips]

Check for goexperimental with golang >= 1.18.

Fixed #81

[openshift-ci-robot]

@rphillips: This pull request references Jira Issue OCPBUGS-24612, which is invalid:

• expected the bug to target the "4.16.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Change the tags check to only run on <= 1.16.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[joepvd]

Think the validator currently does not look at GOEXPERIMENT. This change potentially leads to saying FipsOrDie is enabled, when in reality, it is not.

[openshift-ci-robot]

@rphillips: This pull request references Jira Issue OCPBUGS-24612, which is invalid:

• expected the bug to target the "4.16.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Change the tags check to only run on <= 1.16.

Fixed #81

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[rphillips]

This pr is ready. Passes on 4.14+.

[joepvd]

Think the behavior with this change is:

-tags=strictfipsruntime	GOEXPERIMENT=strictfipsruntime	result
yes	yes	good
yes	no	bad
no	yes	bad
no	no	bad

I think the behavior should be:

-tags=strictfipsruntime	GOEXPERIMENT=strictfipsruntime	result
yes	yes	good
yes	no	good
no	yes	good
no	no	bad

[rphillips]

Thanks. Updated the PR.

[openshift-ci]

@rphillips: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[joepvd]

Nice, thanks!

/lgtm

[openshift-ci]

@joepvd: changing LGTM is restricted to collaborators

In response to this:

Nice, thanks!

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: joepvd, rphillips

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [rphillips]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci-robot]

@rphillips: Jira Issue OCPBUGS-24612: All pull requests linked via external trackers have merged:

• openshift/check-payload#143

Jira Issue OCPBUGS-24612 has been moved to the MODIFIED state.

In response to this:

Check for goexperimental with golang >= 1.18.

Fixed #81

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[dollierp]

Missing parentheses after bracket?: }()

[davdhacs]

I PR'd a change to fix this (execute the function): #240