Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NO-ISSUE: workaround running podman play kube on older versions #3357

Closed
wants to merge 1 commit into from
Closed

NO-ISSUE: workaround running podman play kube on older versions #3357

wants to merge 1 commit into from

Conversation

eifrach
Copy link
Contributor

@eifrach eifrach commented Feb 14, 2022

Signed-off-by: Eran Ifrach eifrach@redhat.com
related to #3312

workaround for running assisted-service with podman play kube in older version
podman bug

List all the issues related to this PR

  • New Feature
  • Enhancement
  • Bug fix
  • Tests
  • Documentation
  • CI/CD

What environments does this code impact?

  • Automation (CI, tools, etc)
  • Cloud
  • Operator Managed Deployments
  • None

How was this code tested?

  • assisted-test-infra environment
  • dev-scripts environment
  • Reviewer's test appreciated
  • Waiting for CI to do a full test run
  • Manual (Elaborate on how it was tested)
  • No tests needed

Assignees

/cc @
/cc @

Checklist

  • [ x] Title and description added to both, commit and PR.
  • Relevant issues have been associated (see CONTRIBUTING guide)
  • Reviewers have been listed
  • This change does not require a documentation update (docstring, docs, README, etc)
  • Does this change include unit-tests (note that code changes require unit-tests)

Reviewers Checklist

  • Are the title and description (in both PR and commit) meaningful and clear?
  • Is there a bug required (and linked) for this change?
  • Should this PR be backported?

Signed-off-by: Eran Ifrach <eifrach@redhat.com>
@openshift-ci openshift-ci bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Feb 14, 2022
@openshift-ci
Copy link

openshift-ci bot commented Feb 14, 2022

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: eifrach
To complete the pull request process, please assign avishayt after the PR has been reviewed.
You can assign the PR to them by writing /assign @avishayt in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Feb 14, 2022
@openshift-ci
Copy link

openshift-ci bot commented Feb 14, 2022

Hi @eifrach. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tsorya
Copy link
Contributor

tsorya commented Feb 14, 2022

@mhrivnak what do you think?

@mhrivnak
Copy link
Member

When I try this, the DB container dies, and I see this:

$ podman logs assisted-installer-db
Password: su: Authentication failure

@eifrach
Copy link
Contributor Author

eifrach commented Feb 15, 2022

@mhrivnak yes i see the issue - this happens on new versions 3.3+
let me try to fix it

/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 15, 2022
@eifrach
Copy link
Contributor Author

eifrach commented Feb 15, 2022

there is a way to make it work -but it looks to me as over complex
requires a script inside the pod config.

maybe we should create a workaround doc instead which make more sense
what do you think? @mhrivnak

@mhrivnak
Copy link
Member

The README currently suggests using a prior release from git history and has a link. That seems likely sufficient for now and is easy for the user to do. I don't think it's worth a lot of work otherwise.

@eifrach
Copy link
Contributor Author

eifrach commented Feb 15, 2022

thanks closing this PR

/close

@eifrach eifrach closed this Feb 15, 2022
@eifrach eifrach deleted the podman-ai-fix branch February 15, 2022 16:39
@openshift-ci
Copy link

openshift-ci bot commented Feb 15, 2022

@eifrach: Closed this PR.

In response to this:

thanks closing this PR

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants